[GitHub] [pulsar] tiny-rain commented on a diff in pull request #20122: [fix][meta] deadlock of zkSessionWatcher when zkConnection loss

["tiny-rain (via GitHub)" <gi...@apache.org>]

tiny-rain commented on code in PR #20122:
URL: https://github.com/apache/pulsar/pull/20122#discussion_r1170847090


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKSessionWatcher.java:
##########
@@ -81,7 +83,8 @@ public void close() throws Exception {
     }
 
     // task that runs every TICK_TIME to check zk connection
-    private synchronized void checkConnectionStatus() {
+    @VisibleForTesting

Review Comment:
   it not used, let me remove it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org