You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/08/13 18:22:05 UTC
[kudu-CR] [Java] KUDU-3677: Fix optional dependencies
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23205 )
Change subject: [Java] KUDU-3677: Fix optional dependencies
......................................................................
Patch Set 5:
> Yes manually verified the issue no longer exists with the fix in
> place. Without the fix, I could see the issue reported.
I have one follow-up question after playing a bit with gradle's dependencyInsight task. I ran it for both the branch-1.17.x and the master branch with this changelist, and gradle still didn't show the com.stumbleupon:async dependency in the runtimeClasspath for the main branch, but it's present in branch-1.17.x.
Does it mean we do something quite unnatural in the publishing phase? Should we be concerned with the absence of this package in the original gradle dependency graph for in master and branch-1.18.x?
./gradlew :kudu-client:dependencyInsight --dependency com.stumbleupon:async --configuration runtimeClasspath
For branch-1.17.x:
> Task :kudu-client:dependencyInsight
com.stumbleupon:async:1.4.1
variant "runtime" [
org.gradle.status = release (not requested)
org.gradle.usage = java-runtime
org.gradle.libraryelements = jar
org.gradle.category = library
Requested attributes not found in the selected variant:
org.gradle.dependency.bundling = external
org.gradle.jvm.environment = standard-jvm
org.gradle.jvm.version = 8
]
com.stumbleupon:async:1.4.1
\--- runtimeClasspath
For master:
> Task :kudu-client:dependencyInsight
No dependencies matching given input were found in configuration ':kudu-client:runtimeClasspath'
--
To view, visit http://gerrit.cloudera.org:8080/23205
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b7593f595b64082d86fb64cbe8f38ff9b2ccb88
Gerrit-Change-Number: 23205
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Aug 2025 18:22:05 +0000
Gerrit-HasComments: No