You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/01/23 18:08:12 UTC

[GitHub] incubator-brooklyn pull request: delete port forwarding when VM is...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/469

    delete port forwarding when VM is deleted

    This includes commits from https://github.com/apache/incubator-brooklyn/pull/468 - please review+merge that first.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/delete-portForwarding-strike2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #469
    
----
commit 32cc1169f1a70a14bdf93e6c44d98edec2b3a111
Author: Aled Sage <al...@gmail.com>
Date:   2015-01-23T11:42:54Z

    JcloudsLocation: make more testable
    
    - allow a custom jclouds ComputeService to be injected, so can
      stub out things like VM creation and deletion

commit 33b94a855026a7698e0946c06443ffd7a7b5204a
Author: Aled Sage <al...@gmail.com>
Date:   2015-01-23T16:56:30Z

    PortForwarding: delete on JcloudsLocation.release
    
    - Adds JcloudsPortForwarderExtension.closePortForwarding
    - Adds PortForwardManager.forgetPortMappings(publicIpId)
    - Fix jcloudsSshMachineLocation.getSshHostAndPort()
    - Replace JcloudsPortforwardingLiveTest with JcloudsPortForwardingStubbedLiveTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: delete port forwarding when VM is...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/469


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: delete port forwarding when VM is...

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/469#issuecomment-71622866
  
    An additional test which creates two machines, releases one machine then checks if the port mappings for the other machine are still around would be nice. Other than that, LGTM, tests pass


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: delete port forwarding when VM is...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/469#issuecomment-71645511
  
    Thanks @nakomis - I've rebased, then added a test for two VMs (ensuring that releasing first does not impact second). Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---