You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/15 23:28:22 UTC
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8858
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/1
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8858 )
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8858 )
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
Patch Set 6: Verified+1
Unrelated flakies in AlterTableRandomized.TestRandomSequence and org.apache.kudu.spark.tools.ITBigLinkedListTest.org.apache.kudu.spark.tools.ITBigLinkedListTest
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 23 Dec 2017 02:23:59 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8858 )
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
Patch Set 6: Code-Review+1
(5 comments)
looks good, just nits
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@205
PS6, Line 205: work.set_num_tablets(1);
nit: this is the default
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@238
PS6, Line 238: ait_until_running()
not your fault, but this should be wrapped in NO_FATALS()
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@248
PS6, Line 248: ASSERT_NE(nullptr, replica.get());
nit: this line is overly defensive because this has already been checked; the contract of GetTabletReplica() is that it returns OK only if it finds the replica.
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@256
PS6, Line 256: wait_until_running()
NO_FATALS(wait_until_running());
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@363
PS6, Line 363:
nit: missing word "the"
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 05 Jan 2018 23:36:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8858
to look at the new patch set (#8).
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
This patch is a part of the work done in the context of KUDU-1097.
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/8
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8858
to look at the new patch set (#2).
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/2
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8858 )
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
Patch Set 6:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc
File src/kudu/integration-tests/ts_tablet_manager-itest.cc:
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@205
PS6, Line 205: work.set_num_tablets(1);
> nit: this is the default
Done
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@238
PS6, Line 238: ait_until_running()
> not your fault, but this should be wrapped in NO_FATALS()
Done
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@248
PS6, Line 248: ASSERT_NE(nullptr, replica.get());
> nit: this line is overly defensive because this has already been checked; t
Done
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@256
PS6, Line 256: wait_until_running()
> NO_FATALS(wait_until_running());
Done
http://gerrit.cloudera.org:8080/#/c/8858/6/src/kudu/integration-tests/ts_tablet_manager-itest.cc@363
PS6, Line 363:
> nit: missing word "the"
Done
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 02:34:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8858
to look at the new patch set (#4).
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/4
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8858 )
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
This patch is a part of the work done in the context of KUDU-1097.
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Reviewed-on: http://gerrit.cloudera.org:8080/8858
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 48 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8858
to look at the new patch set (#3).
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/3
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8858
to look at the new patch set (#5).
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
[tests] update for 3-4-3 replica management scheme (3/3)
Updated scenarios of the following tests to run with 3-4-3 replica
management scheme:
* DiskFailureITest
* TabletCopyFailureITest
* TabletCopyITest
* TsTabletManagerITest
This patch is a part of the work done in the context of KUDU-1097.
Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
---
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
3 files changed, 119 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/8858/5
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [tests] update for 3-4-3 replica management scheme (3/3)
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8858 )
Change subject: [tests] update for 3-4-3 replica management scheme (3/3)
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68e29fcee4e6dbd166ada9f18dac2d8fe351a3b
Gerrit-Change-Number: 8858
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 02:46:30 +0000
Gerrit-HasComments: No