You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/10 04:03:34 UTC

[GitHub] [shardingsphere] wgy8283335 opened a new pull request #12972: feat: change rules and add sub-query test.

wgy8283335 opened a new pull request #12972:
URL: https://github.com/apache/shardingsphere/pull/12972


   Fixes #12709
   
   Changes proposed in this pull request:
   - change rules and add sub-query test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #12972: feat: change rules and add sub-query test.

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #12972:
URL: https://github.com/apache/shardingsphere/pull/12972#discussion_r725641082



##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/planner/QueryOptimizePlannerFactory.java
##########
@@ -49,27 +48,7 @@ private static RelOptPlanner createPlanner() {
     
     private static void setUpRules(final RelOptPlanner planner) {
         planner.addRelTraitDef(ConventionTraitDef.INSTANCE);
-        planner.addRule(EnumerableRules.TO_INTERPRETER);
-        planner.addRule(Bindables.FROM_NONE_RULE);
-        planner.addRule(Bindables.BINDABLE_TABLE_SCAN_RULE);
-        planner.addRule(Bindables.BINDABLE_FILTER_RULE);
-        planner.addRule(Bindables.BINDABLE_PROJECT_RULE);
-        planner.addRule(Bindables.BINDABLE_SORT_RULE);
-        planner.addRule(Bindables.BINDABLE_JOIN_RULE);
-        planner.addRule(Bindables.BINDABLE_SET_OP_RULE);
-        planner.addRule(Bindables.BINDABLE_VALUES_RULE);
-        planner.addRule(Bindables.BINDABLE_AGGREGATE_RULE);
-        planner.addRule(Bindables.BINDABLE_MATCH_RULE);
-        planner.addRule(CoreRules.PROJECT_FILTER_TRANSPOSE);
-        planner.addRule(CoreRules.PROJECT_JOIN_TRANSPOSE);
-        planner.addRule(CoreRules.PROJECT_MERGE);
-        planner.addRule(CoreRules.PROJECT_TABLE_SCAN);
-        planner.addRule(CoreRules.FILTER_INTO_JOIN);
-        planner.addRule(CoreRules.FILTER_PROJECT_TRANSPOSE);
-        planner.addRule(CoreRules.FILTER_SCAN);
-        planner.addRule(EnumerableRules.ENUMERABLE_CORRELATE_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_PROJECT_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_FILTER_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_MATCH_RULE);
+        planner.addRelTraitDef(RelCollationTraitDef.INSTANCE);
+        RelOptUtil.registerDefaultRules(planner, false, true);

Review comment:
       @wgy8283335 Does the registerDefaultRules method include all the rules deleted above?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #12972: feat: change rules and add sub-query test.

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #12972:
URL: https://github.com/apache/shardingsphere/pull/12972#discussion_r725724765



##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/planner/QueryOptimizePlannerFactory.java
##########
@@ -49,27 +48,7 @@ private static RelOptPlanner createPlanner() {
     
     private static void setUpRules(final RelOptPlanner planner) {
         planner.addRelTraitDef(ConventionTraitDef.INSTANCE);
-        planner.addRule(EnumerableRules.TO_INTERPRETER);
-        planner.addRule(Bindables.FROM_NONE_RULE);
-        planner.addRule(Bindables.BINDABLE_TABLE_SCAN_RULE);
-        planner.addRule(Bindables.BINDABLE_FILTER_RULE);
-        planner.addRule(Bindables.BINDABLE_PROJECT_RULE);
-        planner.addRule(Bindables.BINDABLE_SORT_RULE);
-        planner.addRule(Bindables.BINDABLE_JOIN_RULE);
-        planner.addRule(Bindables.BINDABLE_SET_OP_RULE);
-        planner.addRule(Bindables.BINDABLE_VALUES_RULE);
-        planner.addRule(Bindables.BINDABLE_AGGREGATE_RULE);
-        planner.addRule(Bindables.BINDABLE_MATCH_RULE);
-        planner.addRule(CoreRules.PROJECT_FILTER_TRANSPOSE);
-        planner.addRule(CoreRules.PROJECT_JOIN_TRANSPOSE);
-        planner.addRule(CoreRules.PROJECT_MERGE);
-        planner.addRule(CoreRules.PROJECT_TABLE_SCAN);
-        planner.addRule(CoreRules.FILTER_INTO_JOIN);
-        planner.addRule(CoreRules.FILTER_PROJECT_TRANSPOSE);
-        planner.addRule(CoreRules.FILTER_SCAN);
-        planner.addRule(EnumerableRules.ENUMERABLE_CORRELATE_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_PROJECT_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_FILTER_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_MATCH_RULE);
+        planner.addRelTraitDef(RelCollationTraitDef.INSTANCE);
+        RelOptUtil.registerDefaultRules(planner, false, true);

Review comment:
       Yes. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #12972: feat: change rules and add sub-query test.

Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #12972:
URL: https://github.com/apache/shardingsphere/pull/12972#discussion_r725724765



##########
File path: shardingsphere-infra/shardingsphere-infra-optimize/src/main/java/org/apache/shardingsphere/infra/optimize/planner/QueryOptimizePlannerFactory.java
##########
@@ -49,27 +48,7 @@ private static RelOptPlanner createPlanner() {
     
     private static void setUpRules(final RelOptPlanner planner) {
         planner.addRelTraitDef(ConventionTraitDef.INSTANCE);
-        planner.addRule(EnumerableRules.TO_INTERPRETER);
-        planner.addRule(Bindables.FROM_NONE_RULE);
-        planner.addRule(Bindables.BINDABLE_TABLE_SCAN_RULE);
-        planner.addRule(Bindables.BINDABLE_FILTER_RULE);
-        planner.addRule(Bindables.BINDABLE_PROJECT_RULE);
-        planner.addRule(Bindables.BINDABLE_SORT_RULE);
-        planner.addRule(Bindables.BINDABLE_JOIN_RULE);
-        planner.addRule(Bindables.BINDABLE_SET_OP_RULE);
-        planner.addRule(Bindables.BINDABLE_VALUES_RULE);
-        planner.addRule(Bindables.BINDABLE_AGGREGATE_RULE);
-        planner.addRule(Bindables.BINDABLE_MATCH_RULE);
-        planner.addRule(CoreRules.PROJECT_FILTER_TRANSPOSE);
-        planner.addRule(CoreRules.PROJECT_JOIN_TRANSPOSE);
-        planner.addRule(CoreRules.PROJECT_MERGE);
-        planner.addRule(CoreRules.PROJECT_TABLE_SCAN);
-        planner.addRule(CoreRules.FILTER_INTO_JOIN);
-        planner.addRule(CoreRules.FILTER_PROJECT_TRANSPOSE);
-        planner.addRule(CoreRules.FILTER_SCAN);
-        planner.addRule(EnumerableRules.ENUMERABLE_CORRELATE_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_PROJECT_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_FILTER_RULE);
-        planner.addRule(EnumerableRules.ENUMERABLE_MATCH_RULE);
+        planner.addRelTraitDef(RelCollationTraitDef.INSTANCE);
+        RelOptUtil.registerDefaultRules(planner, false, true);

Review comment:
       Yes. @strongduanmu 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #12972: feat: change rules and add sub-query test.

Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #12972:
URL: https://github.com/apache/shardingsphere/pull/12972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #12972: feat: change rules and add sub-query test.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12972:
URL: https://github.com/apache/shardingsphere/pull/12972#issuecomment-939405394


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12972](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54bae58) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ad409b45f45cc68dae4e8cb40023ff3cc0b57c05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad409b4) will **increase** coverage by `0.03%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12972/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12972      +/-   ##
   ============================================
   + Coverage     63.36%   63.40%   +0.03%     
   - Complexity     1362     1370       +8     
   ============================================
     Files          2497     2498       +1     
     Lines         37488    37527      +39     
     Branches       6440     6455      +15     
   ============================================
   + Hits          23756    23795      +39     
   + Misses        11861    11855       -6     
   - Partials       1871     1877       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../optimize/planner/QueryOptimizePlannerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL3BsYW5uZXIvUXVlcnlPcHRpbWl6ZVBsYW5uZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/shardingsphere/scaling/core/job/ScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2NhbGluZ0pvYi5qYXZh) | `78.94% <0.00%> (-21.06%)` | :arrow_down: |
   | [...core/job/progress/yaml/JobProgressYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJvZ3Jlc3MveWFtbC9Kb2JQcm9ncmVzc1lhbWxTd2FwcGVyLmphdmE=) | `90.24% <0.00%> (-9.76%)` | :arrow_down: |
   | [...phere/infra/rewrite/context/SQLRewriteContext.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvcmV3cml0ZS9jb250ZXh0L1NRTFJld3JpdGVDb250ZXh0LmphdmE=) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
   | [...gsphere/scaling/core/job/progress/JobProgress.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJvZ3Jlc3MvSm9iUHJvZ3Jlc3MuamF2YQ==) | `50.00% <0.00%> (-2.64%)` | :arrow_down: |
   | [.../scaling/core/job/preparer/ScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2NhbGluZ0pvYlByZXBhcmVyLmphdmE=) | `66.07% <0.00%> (-0.60%)` | :arrow_down: |
   | [...dingsphere/driver/jdbc/adapter/WrapperAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvV3JhcHBlckFkYXB0ZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...ate/circuit/resultset/CircuitBreakerResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9zdGF0ZS9jaXJjdWl0L3Jlc3VsdHNldC9DaXJjdWl0QnJlYWtlclJlc3VsdFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ma/builder/loader/common/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9sb2FkZXIvY29tbW9uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `86.66% <0.00%> (ø)` | |
   | [...rypt/rewrite/condition/EncryptConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9jb25kaXRpb24vRW5jcnlwdENvbmRpdGlvbkVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [24 more](https://codecov.io/gh/apache/shardingsphere/pull/12972/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ad409b4...54bae58](https://codecov.io/gh/apache/shardingsphere/pull/12972?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org