You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Daniel Gergely <dg...@hortonworks.com> on 2016/02/18 10:44:09 UTC
Re: Review Request 42912: Clients names different on host details
page and filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 18, 2016, 9:44 de)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
ambari-server/src/main/resources/properties.json 4052ad2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 0a5d913
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js 77395f2
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
Thanks,
Daniel Gergely
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
> On febr. 18, 2016, 4:24 du, Robert Nettleton wrote:
> > I've added a few minor issues that need attention, but otherwise the patch looks fine to me.
> >
> > I've reviewed this patch from the perspective of the server-side Ambari changes, the .js code changes should be reviewed by someone with UI expertise.
> >
> > One question though: Why can't this fix be tested end-to-end? Isn't this just a matter of verifying that the UI uses the proper names consistently for the client components listed here?
> >
> > Thanks for providing this patch!
I meant automated tests. Manually it can be tested.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review119629
-----------------------------------------------------------
On febr. 19, 2016, 11:03 de, Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
>
> (Updated febr. 19, 2016, 11:03 de)
>
>
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-14830
> https://issues.apache.org/jira/browse/AMBARI-14830
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
> Displayed names now come from metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
> ambari-server/src/main/resources/properties.json 4052ad2
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
> ambari-web/app/controllers/global/update_controller.js 04e7427
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/mappers/hosts_mapper.js 7691f2b
> ambari-web/app/models/client_component.js 816950c
> ambari-web/app/models/host_component.js a081d62
>
> Diff: https://reviews.apache.org/r/42912/diff/
>
>
> Testing
> -------
>
> The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
>
>
> File Attachments
> ----------------
>
> Branch 2.2.2
> https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review119629
-----------------------------------------------------------
Fix it, then Ship it!
I've added a few minor issues that need attention, but otherwise the patch looks fine to me.
I've reviewed this patch from the perspective of the server-side Ambari changes, the .js code changes should be reviewed by someone with UI expertise.
One question though: Why can't this fix be tested end-to-end? Isn't this just a matter of verifying that the UI uses the proper names consistently for the client components listed here?
Thanks for providing this patch!
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java (line 103)
<https://reviews.apache.org/r/42912/#comment180981>
Why does this property need a setter? If the display name always comes from the metadata, can't this property be immutable?
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java (line 105)
<https://reviews.apache.org/r/42912/#comment180982>
Same as my comment above: Can't this property be immutable, since it is always defined by the metainfo.xml metadata?
- Robert Nettleton
On Feb. 18, 2016, 9:44 a.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 9:44 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-14830
> https://issues.apache.org/jira/browse/AMBARI-14830
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
> Displayed names now come from metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
> ambari-server/src/main/resources/properties.json 4052ad2
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
> ambari-web/app/controllers/global/update_controller.js 0a5d913
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/mappers/hosts_mapper.js 7691f2b
> ambari-web/app/models/client_component.js 816950c
> ambari-web/app/models/host_component.js 77395f2
>
> Diff: https://reviews.apache.org/r/42912/diff/
>
>
> Testing
> -------
>
> The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review119642
-----------------------------------------------------------
+1 for UI changes. It looks good.
- Oleg Nechiporenko
On Feb. 18, 2016, 9:44 a.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 9:44 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-14830
> https://issues.apache.org/jira/browse/AMBARI-14830
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
> Displayed names now come from metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
> ambari-server/src/main/resources/properties.json 4052ad2
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
> ambari-web/app/controllers/global/update_controller.js 0a5d913
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/mappers/hosts_mapper.js 7691f2b
> ambari-web/app/models/client_component.js 816950c
> ambari-web/app/models/host_component.js 77395f2
>
> Diff: https://reviews.apache.org/r/42912/diff/
>
>
> Testing
> -------
>
> The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review119864
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Feb. 19, 2016, 12:03 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 12:03 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-14830
> https://issues.apache.org/jira/browse/AMBARI-14830
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
> Displayed names now come from metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
> ambari-server/src/main/resources/properties.json 4052ad2
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
> ambari-web/app/controllers/global/update_controller.js 04e7427
> ambari-web/app/mappers/components_state_mapper.js 0f2b627
> ambari-web/app/mappers/hosts_mapper.js 7691f2b
> ambari-web/app/models/client_component.js 816950c
> ambari-web/app/models/host_component.js a081d62
>
> Diff: https://reviews.apache.org/r/42912/diff/
>
>
> Testing
> -------
>
> The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
>
>
> File Attachments
> ----------------
>
> Branch 2.2.2
> https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
> On febr. 24, 2016, 7:38 du, Alejandro Fernandez wrote:
> > Daniel, which functional e2e tests have you performed?
I did manual testing:
Compared the filter list and the host summany page to see if the displayed labels are the same. Then I changed displayName field in the metainfo.xml of some components, restarted ambari server and checked the labels again to verify the change.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review120557
-----------------------------------------------------------
On febr. 24, 2016, 3:15 du, Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
>
> (Updated febr. 24, 2016, 3:15 du)
>
>
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-14830
> https://issues.apache.org/jira/browse/AMBARI-14830
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
> Displayed names now come from metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 381b114
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java b339adf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7b866a9
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 1bd60a8
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 2c9d881
> ambari-server/src/main/resources/properties.json 8ccae05
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d24ca09
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
> ambari-web/app/controllers/global/update_controller.js 04e7427
> ambari-web/app/mappers/components_state_mapper.js ac3e1b5
> ambari-web/app/mappers/hosts_mapper.js 7691f2b
> ambari-web/app/models/client_component.js 816950c
> ambari-web/app/models/host_component.js b7a5f5a
> ambari-web/test/models/host_component_test.js 92e3d50
>
> Diff: https://reviews.apache.org/r/42912/diff/
>
>
> Testing
> -------
>
> The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
>
>
> File Attachments
> ----------------
>
> AMBARI-14830_branch-2.2.2.patch
> https://reviews.apache.org/media/uploaded/files/2016/02/24/eecded40-b19e-4a61-8482-d00cd6c05107__AMBARI-14830_branch-2.2.2.patch
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/#review120557
-----------------------------------------------------------
Daniel, which functional e2e tests have you performed?
- Alejandro Fernandez
On Feb. 24, 2016, 3:15 p.m., Daniel Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42912/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 3:15 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
>
>
> Bugs: AMBARI-14830
> https://issues.apache.org/jira/browse/AMBARI-14830
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
> Displayed names now come from metainfo.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 381b114
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java b339adf
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7b866a9
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 1bd60a8
> ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
> ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
> ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 2c9d881
> ambari-server/src/main/resources/properties.json 8ccae05
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d24ca09
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
> ambari-web/app/controllers/global/update_controller.js 04e7427
> ambari-web/app/mappers/components_state_mapper.js ac3e1b5
> ambari-web/app/mappers/hosts_mapper.js 7691f2b
> ambari-web/app/models/client_component.js 816950c
> ambari-web/app/models/host_component.js b7a5f5a
> ambari-web/test/models/host_component_test.js 92e3d50
>
> Diff: https://reviews.apache.org/r/42912/diff/
>
>
> Testing
> -------
>
> The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
>
>
> File Attachments
> ----------------
>
> AMBARI-14830_branch-2.2.2.patch
> https://reviews.apache.org/media/uploaded/files/2016/02/24/eecded40-b19e-4a61-8482-d00cd6c05107__AMBARI-14830_branch-2.2.2.patch
>
>
> Thanks,
>
> Daniel Gergely
>
>
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 24, 2016, 3:15 du)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 381b114
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java b339adf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7b866a9
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 1bd60a8
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 2c9d881
ambari-server/src/main/resources/properties.json 8ccae05
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d24ca09
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 04e7427
ambari-web/app/mappers/components_state_mapper.js ac3e1b5
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js b7a5f5a
ambari-web/test/models/host_component_test.js 92e3d50
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
File Attachments (updated)
----------------
AMBARI-14830_branch-2.2.2.patch
https://reviews.apache.org/media/uploaded/files/2016/02/24/eecded40-b19e-4a61-8482-d00cd6c05107__AMBARI-14830_branch-2.2.2.patch
Thanks,
Daniel Gergely
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 24, 2016, 12:59 du)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Changes
-------
Trunk has been changed again, new patch uploaded.
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 381b114
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java b339adf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7b866a9
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 1bd60a8
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 2c9d881
ambari-server/src/main/resources/properties.json 8ccae05
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d24ca09
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 04e7427
ambari-web/app/mappers/components_state_mapper.js ac3e1b5
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js b7a5f5a
ambari-web/test/models/host_component_test.js 92e3d50
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
File Attachments
----------------
Branch 2.2.2
https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
Thanks,
Daniel Gergely
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 24, 2016, 9:14 de)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Changes
-------
Unnecessary test removed. (the function is not used any more due to the changes in the patch)
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 381b114
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java b339adf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7b866a9
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 2c9d881
ambari-server/src/main/resources/properties.json 8ccae05
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d24ca09
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 04e7427
ambari-web/app/mappers/components_state_mapper.js ac3e1b5
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js b7a5f5a
ambari-web/test/models/host_component_test.js 92e3d50
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
File Attachments
----------------
Branch 2.2.2
https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
Thanks,
Daniel Gergely
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 23, 2016, 2:40 du)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Changes
-------
Updated patch to be compatible with the latest trunk (9310ab7 2016-02-23)
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java 381b114
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java b339adf
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7b866a9
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 2c9d881
ambari-server/src/main/resources/properties.json 8ccae05
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java d24ca09
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 04e7427
ambari-web/app/mappers/components_state_mapper.js ac3e1b5
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js b7a5f5a
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
File Attachments
----------------
Branch 2.2.2
https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
Thanks,
Daniel Gergely
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 19, 2016, 11:03 de)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Changes
-------
Patch for branch 2.2.2
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
ambari-server/src/main/resources/properties.json 4052ad2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 04e7427
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js a081d62
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
File Attachments (updated)
----------------
Branch 2.2.2
https://reviews.apache.org/media/uploaded/files/2016/02/19/37481770-3502-4d82-a2a9-453faf1bb477__AMBARI-14830_branch-2.2.2.patch
Thanks,
Daniel Gergely
Re: Review Request 42912: Clients names different on host details
page and filter
Posted by Daniel Gergely <dg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42912/
-----------------------------------------------------------
(Updated febr. 19, 2016, 11:02 de)
Review request for Ambari, Jaimin Jetly, Oliver Szabo, Oleg Nechiporenko, Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.
Changes
-------
Updated patch for 2.4.0
Bugs: AMBARI-14830
https://issues.apache.org/jira/browse/AMBARI-14830
Repository: ambari
Description
-------
Clients names were different on host details page and filter for components Pig, Sqoop, Slider, Mahout.
Displayed names now come from metainfo.xml
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java c25c970
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java f7dd301
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 3ad6e64
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java a2a58e8
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 7e1dd1d
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java bfb6214
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml bd8ef70
ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/metainfo.xml 27a9c35
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/metainfo.xml a2002f1
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml b5db91b
ambari-server/src/main/resources/properties.json 4052ad2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 7643abb
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java f38fab1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f9c1fe4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c480156
ambari-web/app/controllers/global/update_controller.js 04e7427
ambari-web/app/mappers/components_state_mapper.js 0f2b627
ambari-web/app/mappers/hosts_mapper.js 7691f2b
ambari-web/app/models/client_component.js 816950c
ambari-web/app/models/host_component.js a081d62
Diff: https://reviews.apache.org/r/42912/diff/
Testing
-------
The existing unit tests are aligned to the modifications, but I did not find a way to e2e test the fix.
Thanks,
Daniel Gergely