You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/01/25 03:55:23 UTC

[07/10] james-project git commit: MAILBOX-374 Avoid a race condition upon connection recovery

MAILBOX-374 Avoid a race condition upon connection recovery

This will lead to multiple connection opening, waisting resources


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/4270f4f7
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/4270f4f7
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/4270f4f7

Branch: refs/heads/master
Commit: 4270f4f7bb5288895b9cba3eaf143fcef506174e
Parents: e255eae
Author: Benoit Tellier <bt...@linagora.com>
Authored: Thu Jan 24 22:38:12 2019 +0700
Committer: Benoit Tellier <bt...@linagora.com>
Committed: Fri Jan 25 10:33:25 2019 +0700

----------------------------------------------------------------------
 .../apache/james/backend/rabbitmq/RabbitMQConnectionFactory.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/4270f4f7/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/RabbitMQConnectionFactory.java
----------------------------------------------------------------------
diff --git a/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/RabbitMQConnectionFactory.java b/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/RabbitMQConnectionFactory.java
index ac469e4..151e983 100644
--- a/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/RabbitMQConnectionFactory.java
+++ b/backends-common/rabbitmq/src/main/java/org/apache/james/backend/rabbitmq/RabbitMQConnectionFactory.java
@@ -41,7 +41,7 @@ public class RabbitMQConnectionFactory {
         }
 
         @Override
-        public Connection call() throws Exception {
+        public synchronized Connection call() throws Exception {
             if (connection.map(Connection::isOpen).orElse(false)) {
                 return connection.get();
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org