You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by id...@apache.org on 2007/05/23 11:52:05 UTC
svn commit: r540910 - in /myfaces/tobago/trunk:
example/demo/src/main/webapp/overview/tab.jsp
theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties
Author: idus
Date: Wed May 23 02:52:04 2007
New Revision: 540910
URL: http://svn.apache.org/viewvc?view=rev&rev=540910
Log:
cosmetic: avoid superfluous scrollbars in tabs for Richmond theme and make sure inner dimensions are correctly propagated to tabs, because tabs currently have no default layout manager
Modified:
myfaces/tobago/trunk/example/demo/src/main/webapp/overview/tab.jsp
myfaces/tobago/trunk/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties
Modified: myfaces/tobago/trunk/example/demo/src/main/webapp/overview/tab.jsp
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/example/demo/src/main/webapp/overview/tab.jsp?view=diff&rev=540910&r1=540909&r2=540910
==============================================================================
--- myfaces/tobago/trunk/example/demo/src/main/webapp/overview/tab.jsp (original)
+++ myfaces/tobago/trunk/example/demo/src/main/webapp/overview/tab.jsp Wed May 23 02:52:04 2007
@@ -34,102 +34,90 @@
<tc:tabGroup id="tabs" state="#{demo.tabState0}" >
<tc:tab label="#{overviewBundle.tabClientSide}" >
-
+ <f:facet name="layout"><tc:gridLayout /></f:facet>
<tc:tabGroup id="tabMarsOuterForm" state="#{demo.tabState1}" >
<tc:tab label="#{overviewBundle.tabPlanet}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].diameter}"
- label="#{overviewBundle.solarPlanetDiameter}" />
- <tx:in value="#{demo.solar.planets[0].mass}"
- label="#{overviewBundle.solarPlanetMass}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].diameter}"
+ label="#{overviewBundle.solarPlanetDiameter}" />
+ <tx:in value="#{demo.solar.planets[0].mass}"
+ label="#{overviewBundle.solarPlanetMass}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabInsolar}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].sunDistance}"
- label="#{overviewBundle.solarPlanetSunDistance}" />
- <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
- label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].sunDistance}"
+ label="#{overviewBundle.solarPlanetSunDistance}" />
+ <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
+ label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabMoons}">
- <tc:panel>
- <f:facet name="layout"><tc:gridLayout /></f:facet>
- <tc:sheet value="#{demo.solar.planets[0].moons}"
- columns="2*;1*;2*;2*" var="moon">
- <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
- <tc:out value="#{moon.name}" id="t_name" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
- <tc:out value="#{moon.number}" id="t_number"/>
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
- <tc:out value="#{moon.distance}" id="t_distance" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
- <tc:out value="#{moon.period}" id="t_period" />
- </tc:column>
- </tc:sheet>
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout /></f:facet>
+ <tc:sheet value="#{demo.solar.planets[0].moons}"
+ columns="2*;1*;2*;2*" var="moon">
+ <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
+ <tc:out value="#{moon.name}" id="t_name" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
+ <tc:out value="#{moon.number}" id="t_number"/>
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
+ <tc:out value="#{moon.distance}" id="t_distance" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
+ <tc:out value="#{moon.period}" id="t_period" />
+ </tc:column>
+ </tc:sheet>
</tc:tab>
</tc:tabGroup>
</tc:tab>
<tc:tab label="#{overviewBundle.tabServerSide}" >
-
+ <f:facet name="layout"><tc:gridLayout /></f:facet>
<tc:tabGroup id="tabMarsOuterForm2" switchType="reloadTab" state="#{demo.tabState2}" >
<tc:tabChangeListener type="org.apache.myfaces.tobago.example.demo.actionlistener.SimpleTabChangeListener"
binding="#{demo.tabChangeListener}" />
<tc:tab label="#{overviewBundle.tabPlanet}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].diameter}"
- label="#{overviewBundle.solarPlanetDiameter}" />
- <tx:in value="#{demo.solar.planets[0].mass}"
- label="#{overviewBundle.solarPlanetMass}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].diameter}"
+ label="#{overviewBundle.solarPlanetDiameter}" />
+ <tx:in value="#{demo.solar.planets[0].mass}"
+ label="#{overviewBundle.solarPlanetMass}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabInsolar}">
- <tc:panel >
- <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
- <tc:cell />
- <tx:in value="#{demo.solar.planets[0].sunDistance}"
- label="#{overviewBundle.solarPlanetSunDistance}" />
- <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
- label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
- <tc:cell />
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout rows="1*;fixed;fixed;1*" /></f:facet>
+ <tc:cell />
+ <tx:in value="#{demo.solar.planets[0].sunDistance}"
+ label="#{overviewBundle.solarPlanetSunDistance}" />
+ <tx:in value="#{demo.solar.planets[0].timeOfCirculation}"
+ label="#{overviewBundle.solarPlanetTimeOfCirculation}" />
+ <tc:cell />
</tc:tab>
<tc:tab label="#{overviewBundle.tabMoons}">
- <tc:panel>
- <f:facet name="layout"><tc:gridLayout /></f:facet>
- <tc:sheet value="#{demo.solar.planets[0].moons}"
- columns="2*;1*;2*;2*" var="moon">
- <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
- <tc:out value="#{moon.name}" id="t_name" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
- <tc:out value="#{moon.number}" id="t_number"/>
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
- <tc:out value="#{moon.distance}" id="t_distance" />
- </tc:column>
- <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
- <tc:out value="#{moon.period}" id="t_period" />
- </tc:column>
- </tc:sheet>
- </tc:panel>
+ <f:facet name="layout"><tc:gridLayout /></f:facet>
+ <tc:sheet value="#{demo.solar.planets[0].moons}"
+ columns="2*;1*;2*;2*" var="moon">
+ <tc:column label="#{overviewBundle.solarArrayName}" id="name" sortable="true">
+ <tc:out value="#{moon.name}" id="t_name" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayNumber}" id="number" sortable="false" align="center" >
+ <tc:out value="#{moon.number}" id="t_number"/>
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayDistance}" sortable="true" align="right" >
+ <tc:out value="#{moon.distance}" id="t_distance" />
+ </tc:column>
+ <tc:column label="#{overviewBundle.solarArrayPeriod}" sortable="true" align="right" >
+ <tc:out value="#{moon.period}" id="t_period" />
+ </tc:column>
+ </tc:sheet>
</tc:tab>
</tc:tabGroup>
Modified: myfaces/tobago/trunk/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties?view=diff&rev=540910&r1=540909&r2=540910
==============================================================================
--- myfaces/tobago/trunk/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties (original)
+++ myfaces/tobago/trunk/theme/richmond/src/main/resources/org/apache/myfaces/tobago/renderkit/html/richmond/standard/property/tobago-theme-config.properties Wed May 23 02:52:04 2007
@@ -17,6 +17,6 @@
# padding-top + padding-bottom + border-top + border-bottom
-TabGroup.paddingHeight=27
+TabGroup.paddingHeight=28
# padding-left + padding-right + border-left + border-right
TabGroup.paddingWidth=25