You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "spyhunter99 (via GitHub)" <gi...@apache.org> on 2025/11/12 00:37:41 UTC
[PR] JSPWIKI-1228 audit logging capability with optional email based alert… [jspwiki]
spyhunter99 opened a new pull request, #429:
URL: https://github.com/apache/jspwiki/pull/429
…ing mechanism. Some minor api changes were required to get all the necessary information available in all contexts. This also includes a low disk space warning event.
JSPWIKI-615 more related javadoc updates for the eventing system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1228 audit logging capability with optional email based alert… [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #429:
URL: https://github.com/apache/jspwiki/pull/429#issuecomment-3534906242
maybe we should make this an optional feature as it will generate a lot of logs
and maybe the email sender should be in a threadpool to prevent slow responding servers from causing an overall performance degradation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1228 audit logging capability with optional email based alert… [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 merged PR #429:
URL: https://github.com/apache/jspwiki/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1228 audit logging capability with optional email based alert… [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on code in PR #429:
URL: https://github.com/apache/jspwiki/pull/429#discussion_r2529138991
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEvent.java:
##########
@@ -42,14 +44,20 @@ public abstract class WikiEvent extends EventObject {
/** objects associated to src which only make sense in the context of a given WikiEvent */
private Object[] args;
+
+ private Map<Object,Object> attributes = new HashMap<>();
Review Comment:
javadocs
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEvent.java:
##########
@@ -42,14 +44,20 @@ public abstract class WikiEvent extends EventObject {
/** objects associated to src which only make sense in the context of a given WikiEvent */
private Object[] args;
+
+ private Map<Object,Object> attributes = new HashMap<>();
+
+ public Map<Object, Object> getAttributes() {
Review Comment:
javadocs
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java:
##########
@@ -127,7 +127,7 @@ public final class WikiEventManager {
private static final Logger LOG = LogManager.getLogger(WikiEventManager.class);
/* If true, permits a WikiEventMonitor to be set. */
- private static final boolean c_permitMonitor = false;
+ private static final boolean c_permitMonitor = true;
Review Comment:
for discussion. i'm not 100% sure what other effects this will have for enabling this but it was required to get a global listener working. the eventing system i'm still a bit unsure why it is like it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org