[GitHub] [airflow] khalidmammadov commented on a change in pull request #20881: Fix a test case inside tests/models that leaves a trace in the DB

[GitBox <gi...@apache.org>]

khalidmammadov commented on a change in pull request #20881:
URL: https://github.com/apache/airflow/pull/20881#discussion_r785303071



##########
File path: tests/models/test_dagbag.py
##########
@@ -837,6 +837,7 @@ def _sync_perms():
             mock_sync_perm_for_dag.assert_called_once_with(
                 "test_example_bash_operator", {"Public": {"can_read"}}
             )
+        delete_dag_specific_permissions()

Review comment:
       This suite uses unittest and hence added to setup and clear down instead. Also. moved the function `as is` into `db.py` module under `test_utils` for consistency and removed `permissions.py` as it's not required anymore. Is that OK?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org