You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/04 16:31:16 UTC
[GitHub] [incubator-nuttx] AlanRosenthal opened a new pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
AlanRosenthal opened a new pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163
## Summary
This PR renames `tools/Makefile.*` to have the `.mk` extension. This PR also updates `README.md` and other files that references the other files.
## Impact
By using a standard extension for Makefiles (https://www.file-extension.info/format/mk), editors will auto-format files.
This change will also improve developer ergonomics when searching for specific files
## Testing
Verified locally that build still works, CI will verify more!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#issuecomment-1004992994
@AlanRosenthal we've got sone chicken'n'egg conflicts here. :)
Now that https://github.com/apache/incubator-nuttx/pull/5147 is merged, this PR has conflicts. It will also have the another conflict when https://github.com/apache/incubator-nuttx/pull/5162 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] AlanRosenthal commented on a change in pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
Posted by GitBox <gi...@apache.org>.
AlanRosenthal commented on a change in pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#discussion_r778290301
##########
File path: boards/mips/pic32mz/pic32mz-starterkit/README.txt
##########
@@ -78,9 +78,9 @@ On Board Debug Support
The starter kit includes a PIC24FJ256GB106 USB microcontroller that
provides debugger connectivity over USB. The PIC24FJ256GB106 is hard-wired
to the PIC32 device to provide protocol translation through the I/O pins
- of the PIC24FJ256GB106 to the ICSP� pins of the PIC32 device.
+ of the PIC24FJ256GB106 to the ICSP� pins of the PIC32 device.
- If MPLAB� REAL ICE� or MPLAB ICD 3 is used with the starter kit,
+ If MPLAB� REAL ICE� or MPLAB ICD 3 is used with the starter kit,
Review comment:
weird, not sure what happened here. will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#issuecomment-1005506757
@Ouss4 do you think the rename is good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#discussion_r778288307
##########
File path: boards/mips/pic32mz/pic32mz-starterkit/README.txt
##########
@@ -78,9 +78,9 @@ On Board Debug Support
The starter kit includes a PIC24FJ256GB106 USB microcontroller that
provides debugger connectivity over USB. The PIC24FJ256GB106 is hard-wired
to the PIC32 device to provide protocol translation through the I/O pins
- of the PIC24FJ256GB106 to the ICSP� pins of the PIC32 device.
+ of the PIC24FJ256GB106 to the ICSP� pins of the PIC32 device.
- If MPLAB� REAL ICE� or MPLAB ICD 3 is used with the starter kit,
+ If MPLAB� REAL ICE� or MPLAB ICD 3 is used with the starter kit,
Review comment:
ditto
##########
File path: boards/mips/pic32mz/pic32mz-starterkit/README.txt
##########
@@ -78,9 +78,9 @@ On Board Debug Support
The starter kit includes a PIC24FJ256GB106 USB microcontroller that
provides debugger connectivity over USB. The PIC24FJ256GB106 is hard-wired
to the PIC32 device to provide protocol translation through the I/O pins
- of the PIC24FJ256GB106 to the ICSP� pins of the PIC32 device.
+ of the PIC24FJ256GB106 to the ICSP� pins of the PIC32 device.
Review comment:
revert the change?
##########
File path: boards/mips/pic32mx/pic32mx-starterkit/README.txt
##########
@@ -522,7 +522,7 @@ On Board Debug Support
that provides debugger connectivity over USB. The PIC32MX440F512H is hard-wired
to the PIC32 device to provide two types of protocol translation:
- - I/O pins of PIC32MX440F512H to the ICSP� pins of the PIC32
+ - I/O pins of PIC32MX440F512H to the ICSP� pins of the PIC32
Review comment:
revert
##########
File path: boards/mips/pic32mx/pic32mx-starterkit/README.txt
##########
@@ -1038,7 +1038,7 @@ Where <subdir> is one of the following:
as NSH built-in built in functions.
To use USB device, connect the starter kit to the host using a cable
- with a Type-B micro-plug to the starter kit�s micro-A/B port J5, located
+ with a Type-B micro-plug to the starter kit�s micro-A/B port J5, located
Review comment:
revert the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #5163: Rename `tools/Makefile.*` to have the `.mk` extension
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #5163:
URL: https://github.com/apache/incubator-nuttx/pull/5163#issuecomment-1004992994
@AlanRosenthal we've got sone chicken'n'egg conflicts here. :)
Now that https://github.com/apache/incubator-nuttx/pull/5147 is merged, this PR has conflicts. It will also have another conflict when https://github.com/apache/incubator-nuttx/pull/5162 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org