You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/04/21 18:43:37 UTC
[kudu-CR](branch-1.12.x) [test] Fix types-test on MacOS
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15773
Change subject: [test] Fix types-test on MacOS
......................................................................
[test] Fix types-test on MacOS
In MacOS the `%F` date format pads the date with leading zeros. While
on other linux distributions it does not. It appears to be an issue for other
software as well:
https://bugs.python.org/issue32195
As a quick workaround I added special handling to the test for leading
zeros.
Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Reviewed-on: http://gerrit.cloudera.org:8080/15768
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit d7a3cddd217d0de513483b3a9f911d83e1eeb5d2)
---
M src/kudu/common/types-test.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/15773/1
--
To view, visit http://gerrit.cloudera.org:8080/15773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Gerrit-Change-Number: 15773
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.12.x) [test] Fix types-test on MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15773 )
Change subject: [test] Fix types-test on MacOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Gerrit-Change-Number: 15773
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 19:41:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [test] Fix types-test on MacOS
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15773 )
Change subject: [test] Fix types-test on MacOS
......................................................................
[test] Fix types-test on MacOS
In MacOS the `%F` date format pads the date with leading zeros. While
on other linux distributions it does not. It appears to be an issue for other
software as well:
https://bugs.python.org/issue32195
As a quick workaround I added special handling to the test for leading
zeros.
Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Reviewed-on: http://gerrit.cloudera.org:8080/15768
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit d7a3cddd217d0de513483b3a9f911d83e1eeb5d2)
Reviewed-on: http://gerrit.cloudera.org:8080/15773
Reviewed-by: Volodymyr Verovkin <ve...@cloudera.com>
---
M src/kudu/common/types-test.cc
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Volodymyr Verovkin: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Gerrit-Change-Number: 15773
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR](branch-1.12.x) [test] Fix types-test on MacOS
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15773 )
Change subject: [test] Fix types-test on MacOS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic11d2e1828e141f678ea8f417c57b188e322c660
Gerrit-Change-Number: 15773
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 19:22:37 +0000
Gerrit-HasComments: No