You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 12:33:26 UTC
[GitHub] [flink] V1ncentzzZ commented on a change in pull request #14326: [FLINK-20520][metrics][docs] Document metric name escaping
V1ncentzzZ commented on a change in pull request #14326:
URL: https://github.com/apache/flink/pull/14326#discussion_r538309773
##########
File path: docs/ops/metrics.zh.md
##########
@@ -1654,6 +1654,9 @@ Request metrics aggregated over a subset of all entities of the respective type:
- `/jobs/metrics?jobs=D,E,F`
- `/jobs/<jobid>/vertices/<vertexid>/subtasks/metrics?subtask=1,2,3`
+<span class="label label-danger">Warning</span> Metric names can contain special characters (`?`, `&`, `$`, `+`, `/`, `,`, `:`, `=`, `@`, `%`) that you need to be escape when querying metrics.
+For example, `"a_+_b`" would be escaped to "`a_%2B_b`".
Review comment:
Same problem as before.
##########
File path: docs/ops/metrics.md
##########
@@ -1654,6 +1654,9 @@ Request metrics aggregated over a subset of all entities of the respective type:
- `/jobs/metrics?jobs=D,E,F`
- `/jobs/<jobid>/vertices/<vertexid>/subtasks/metrics?subtask=1,2,3`
+<span class="label label-danger">Warning</span> Metric names can contain special characters (`?`, `&`, `$`, `+`, `/`, `,`, `:`, `=`, `@`, `%`) that you need to be escape when querying metrics.
+For example, `"a_+_b`" would be escaped to "`a_%2B_b`".
Review comment:
Maybe "\`a_+\_b\`" instead of \`"a_+_b\`"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org