You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:04:51 UTC
[GitHub] [superset] geido opened a new pull request, #19586: fix: Navbar styles and Welcome page text
geido opened a new pull request, #19586:
URL: https://github.com/apache/superset/pull/19586
### SUMMARY
It fixes an issue with the text in the Welcome page not appearing as reported here https://github.com/apache/superset/pull/19579. It also enhances the styles to follow our guidelines.
### BEFORE
### AFTER
### TESTING INSTRUCTIONS
1. Go to the login page and make sure the logo appears in the right size immediately
2. Go to the Welcome page and make sure the text "Home" at the top is displaying correctly.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a diff in pull request #19586: fix: Navbar styles and Welcome page text
Posted by GitBox <gi...@apache.org>.
etr2460 commented on code in PR #19586:
URL: https://github.com/apache/superset/pull/19586#discussion_r845560092
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -113,23 +113,31 @@ const WelcomeContainer = styled.div`
`;
const WelcomeNav = styled.div`
- height: 50px;
- background-color: white;
- .navbar-brand {
- margin-left: ${({ theme }) => theme.gridUnit * 2}px;
- font-weight: ${({ theme }) => theme.typography.weights.bold};
- }
- .switch {
- float: right;
- margin: ${({ theme }) => theme.gridUnit * 5}px;
- display: flex;
- flex-direction: row;
- span {
- display: block;
- margin: ${({ theme }) => theme.gridUnit * 1}px;
- line-height: 1;
+ ${({ theme }) => `
+ height: 50px;
+ background-color: ${theme.colors.grayscale.light5};
+ & > span {
Review Comment:
can we give this a class name instead? this is a bit fragile
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -113,23 +113,31 @@ const WelcomeContainer = styled.div`
`;
const WelcomeNav = styled.div`
- height: 50px;
- background-color: white;
- .navbar-brand {
- margin-left: ${({ theme }) => theme.gridUnit * 2}px;
- font-weight: ${({ theme }) => theme.typography.weights.bold};
- }
- .switch {
- float: right;
- margin: ${({ theme }) => theme.gridUnit * 5}px;
- display: flex;
- flex-direction: row;
- span {
- display: block;
- margin: ${({ theme }) => theme.gridUnit * 1}px;
- line-height: 1;
+ ${({ theme }) => `
+ height: 50px;
+ background-color: ${theme.colors.grayscale.light5};
+ & > span {
+ display: flex;
+ float: left;
Review Comment:
why do we need float on this if we're displaying flex?
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -275,7 +283,7 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
return (
<WelcomeContainer>
<WelcomeNav>
- <span className="navbar-brand">Home</span>
+ <span>Home</span>
Review Comment:
should this be an `h1` or an `h2` since it's the title of the page?
##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -113,23 +113,31 @@ const WelcomeContainer = styled.div`
`;
const WelcomeNav = styled.div`
- height: 50px;
- background-color: white;
- .navbar-brand {
- margin-left: ${({ theme }) => theme.gridUnit * 2}px;
- font-weight: ${({ theme }) => theme.typography.weights.bold};
- }
- .switch {
- float: right;
- margin: ${({ theme }) => theme.gridUnit * 5}px;
- display: flex;
- flex-direction: row;
- span {
- display: block;
- margin: ${({ theme }) => theme.gridUnit * 1}px;
- line-height: 1;
+ ${({ theme }) => `
+ height: 50px;
+ background-color: ${theme.colors.grayscale.light5};
+ & > span {
+ display: flex;
+ float: left;
+ height: 50px;
Review Comment:
should this be a multiple of gridUnit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #19586: fix: Navbar styles and Welcome page text
Posted by GitBox <gi...@apache.org>.
geido merged PR #19586:
URL: https://github.com/apache/superset/pull/19586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19586: fix: Navbar styles and Welcome page text
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19586:
URL: https://github.com/apache/superset/pull/19586#issuecomment-1096844290
# [Codecov](https://codecov.io/gh/apache/superset/pull/19586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19586](https://codecov.io/gh/apache/superset/pull/19586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ee288c) into [master](https://codecov.io/gh/apache/superset/commit/7b0b029318a4cd6da7bbc54a79390c61322ded95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7b0b029) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 8ee288c differs from pull request most recent head 392a9bb. Consider uploading reports for the commit 392a9bb to get more accurate results
```diff
@@ Coverage Diff @@
## master #19586 +/- ##
==========================================
- Coverage 66.47% 66.46% -0.01%
==========================================
Files 1681 1681
Lines 64467 64448 -19
Branches 6607 6607
==========================================
- Hits 42856 42837 -19
Misses 19917 19917
Partials 1694 1694
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.12% <100.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/19586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `74.22% <100.00%> (-0.78%)` | :arrow_down: |
| [superset-frontend/src/views/components/Menu.tsx](https://codecov.io/gh/apache/superset/pull/19586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NvbXBvbmVudHMvTWVudS50c3g=) | `50.00% <100.00%> (-10.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19586?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19586?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7b0b029...392a9bb](https://codecov.io/gh/apache/superset/pull/19586?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org