[GitHub] [httpcomponents-client] ok2c commented on pull request #420: Fix calculation of freshness lifetime in HttpResponse

["ok2c (via GitHub)" <gi...@apache.org>]

ok2c commented on PR #420:
URL: https://github.com/apache/httpcomponents-client/pull/420#issuecomment-1461566576

   @arturobernalg That is much better, but you can still improve it further. Please note that your method executes the same logic twice inside the loop. Please optimize it. You may also want to create a separate test case just for the parser. Once this is done I will suggest further improvements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org