You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/27 18:10:44 UTC
[GitHub] [hudi] nsivabalan commented on a diff in pull request #7052: [MINOR] Make sure Dictionary Encoding in Parquet enabled by default
nsivabalan commented on code in PR #7052:
URL: https://github.com/apache/hudi/pull/7052#discussion_r1007209772
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieParquetConfig.java:
##########
@@ -37,7 +37,7 @@
public HoodieParquetConfig(T writeSupport, CompressionCodecName compressionCodecName, int blockSize,
int pageSize, long maxFileSize, Configuration hadoopConf, double compressionRatio) {
- this(writeSupport, compressionCodecName, blockSize, pageSize, maxFileSize, hadoopConf, compressionRatio, false);
+ this(writeSupport, compressionCodecName, blockSize, pageSize, maxFileSize, hadoopConf, compressionRatio, true);
Review Comment:
can we do HoodieStorageConfig.PARQUET_DICTIONARY_ENABLED.defaultValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org