[jira] [Commented] (BOOKKEEPER-827) change throttle in GarbageCollector from "by entry" to "by byte"

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245798#comment-14245798 ] 

Hadoop QA commented on BOOKKEEPER-827:
--------------------------------------

Testing JIRA BOOKKEEPER-827


Patch [BOOKKEEPER-827.patch|https://issues.apache.org/jira/secure/attachment/12687089/BOOKKEEPER-827.patch] downloaded at Sun Dec 14 02:50:14 UTC 2014

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:red}-1 JAVADOC{color}
.    {color:red}-1{color} the patch seems to introduce 1 new Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
.    Tests run: 943
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/882/

> change throttle in GarbageCollector from "by entry" to "by byte"
> ----------------------------------------------------------------
>
>                 Key: BOOKKEEPER-827
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-827
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>    Affects Versions: 4.3.0
>            Reporter: zhaijia
>            Assignee: zhaijia
>             Fix For: 4.4.0, 4.3.1
>
>         Attachments: BOOKKEEPER-827.patch
>
>
> Current bookie compaction in GarbageCollector has two settings: 'compactionMaxOutstandingRequests' and 'compactionRate'. They are throttling and limiting the compaction by entries. 
> But from a bandwidth perspective, it would be good that we could throttle and limit compaction by bytes, which would really reflect the bandwidth of disk. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)