You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2023/01/13 22:23:33 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #9042: Eliminate a redundant data copy in H3 framer

maskit commented on code in PR #9042:
URL: https://github.com/apache/trafficserver/pull/9042#discussion_r1070128044


##########
proxy/http3/Http3DataFramer.cc:
##########
@@ -37,7 +37,7 @@ Http3DataFramer::generate_frame()
   Http3FrameUPtr frame   = Http3FrameFactory::create_null_frame();
   IOBufferReader *reader = this->_source_vio->get_reader();
 
-  size_t payload_len = 128 * 1024;
+  size_t payload_len = 1024 * 1024;

Review Comment:
   Depends on what you mean by send. It just try not to split data too much near the source. I don't remember the detail but the data chunk from cache has 1MB in size, IIRC.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org