You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2013/06/14 14:32:14 UTC

Re: [jclouds] JCLOUDS-127 (#32)

I'd change a few things in this commit:

* I'd add only one method to the interface: isOpen() or isClosed(), as one result implies the other.
* If you want to use the OPEN and CLOSED states instead of a boolean flag, use an enum instead of three ints.
* There is no need to lock the method: Just add a default constructor that sets the state to open, and change it to closed once the loop in the close() is done.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/32#issuecomment-19454386