You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/01 13:53:08 UTC
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new issue #1666: [BUG] Fix SonarCloud bug “Resources should be closed”
Jave-Chen opened a new issue #1666: [BUG] Fix SonarCloud bug “Resources should be closed”
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1666
Description
Connections, streams, files, and other classes that implement the Closeable interface or its super-interface, AutoCloseable, needs to be closed after use. Further, that close call must be made in a finally block otherwise an exception could keep the call from being made. Preferably, when class implements AutoCloseable, resource should be created using "try-with-resources" pattern and will be closed automatically.
Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box it's on to their knees.
Soucre file：
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/ZooKeeperState.java
link：
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvjupYzPBRjkobYuj&open=AW9PvjupYzPBRjkobYuj
https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&issues=AW9PvjupYzPBRjkobYuk&open=AW9PvjupYzPBRjkobYuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #1666: [BUG] Fix SonarCloud bug “Resources should be closed”
Posted by GitBox <gi...@apache.org>.
dailidong closed issue #1666: [BUG] Fix SonarCloud bug “Resources should be closed”
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services