You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/12/05 19:20:38 UTC
[GitHub] [helix] helix-bot commented on a diff in pull request #2303: Add npm run build:mvn script to enable building helix-front module with maven
helix-bot commented on code in PR #2303:
URL: https://github.com/apache/helix/pull/2303#discussion_r1039989130
##########
helix-front/pom.xml:
##########
@@ -154,6 +154,22 @@
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>execution-name</id>
+ <configuration combine.self="override">
+ <suiteXmlFiles>
+ <suiteXmlFile>helix-common/src/test/conf/testng.xml</suiteXmlFile>
Review Comment:
@qqu0127 That's a good idea, let's do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org