You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/20 11:46:14 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9262: ARROW-11317: [Rust] Include the prettyprint feature in CI Coverage

alamb commented on a change in pull request #9262:
URL: https://github.com/apache/arrow/pull/9262#discussion_r560898665



##########
File path: .github/workflows/rust.yml
##########
@@ -109,14 +109,14 @@ jobs:
           export CARGO_HOME="/github/home/.cargo"
           export CARGO_TARGET_DIR="/github/home/target"
           cd rust
-          cargo test
+          # run tests on all workspace members
+          cargo test --all --features=prettyprint
           # test datafusion examples
           cd datafusion
           cargo run --example csv_sql
           cargo run --example parquet_sql
           cd ..
           cd arrow
-          cargo test

Review comment:
       In fact the CI test failed, exactly as you predicted https://github.com/apache/arrow/runs/1727917047 -- namely that you can't specify `--features` in the root of the workspace:
   
   ```
   Run export CARGO_HOME="/github/home/.cargo"
   error: --features is not allowed in the root of a virtual workspace
   note: while this was previously accepted, it didn't actually do anything
   help: change the current directory to the package directory, or use the --manifest-path flag to the path of the package
   Error: Process completed with exit code 101.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org