You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/26 08:00:00 UTC
[jira] [Commented] (NIFI-9332) Correct Conditional SecureHasher
JUnit 5 Tests
[ https://issues.apache.org/jira/browse/NIFI-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434172#comment-17434172 ]
ASF subversion and git services commented on NIFI-9332:
-------------------------------------------------------
Commit a9af5d34651318f938a12461cb5524bca17cb750 in nifi's branch refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a9af5d3 ]
NIFI-9332 Corrected SecureHasher conditional test methods
- Removed GroovyTestCase super class
- Replaced shouldFail() with assertThrows()
Signed-off-by: Pierre Villard <pi...@gmail.com>
This closes #5481.
> Correct Conditional SecureHasher JUnit 5 Tests
> ----------------------------------------------
>
> Key: NIFI-9332
> URL: https://issues.apache.org/jira/browse/NIFI-9332
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Reporter: David Handermann
> Assignee: David Handermann
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Recent updates to SecureHasher unit tests in {{nifi-security-utils}} changed ignored test methods to use the JUnit 5 {{EnabledIfSystemProperty}} annotation. These test classes extend {{GroovyTestCase}}, which does not honor the conditional annotation. Removing the super class extension resolves the issue and avoids running the annotated test methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)