[Bug 54783] Tomcat 6 DeltaManager poses significant performance overhead for Application

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54783

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
(In reply to comment #0)
> On looking at Tomcat 6 source, here are possible causes we identified and
> our suggestions.

Source code review is just about the worst possible way to try and identify a
performance bottleneck. You'd have just about as much success if you closed
your eyes and stuck a pin in a printout of the source code. You need to use a
profiler (I use YourKit because they give free copies to open source developers
to use on their open source projects but there are a number of profilers
available).

> #1 Need early evaluation of Filters:

I don't see anything particularly excessive in terms of the checks that are
performed before the filters are evaluated. Also, the best order for evaluation
will be application dependent. The current order seems reasonable for the
majority of users. I'll need to see some hard evidence from a profiler before
any changes here get my support.

> #2 Minimize Session locking in DeltaManager requestCompleted method

I don't see any simple way to reduce the locking while retaining functionally
correct behaviour.

> Going further, after a copy / clone of DeltaSession is done, could the
> Response be sent back to the Browser and the DeltaSession processing for
> replication done asynchronously in a seperate Thread / by using a seperate
> Thread Pool?

Already supported and used by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org