You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by aparnard <gi...@git.apache.org> on 2016/06/28 23:08:57 UTC
[GitHub] incubator-geode pull request #176: GEODE-1558: Fixing failures due to rebala...
GitHub user aparnard opened a pull request:
https://github.com/apache/incubator-geode/pull/176
GEODE-1558: Fixing failures due to rebalancing buckets during lucene \u2026
\u2026index updates
There are two failures we're fixing here:
1) Calling repository.create for create events was leaving duplicate events in the
index because when a bucket fails over, the event is dispatched again on the new primary.
Using the isPossibleDuplicate flag did not work because it was not consistently set to
true for duplicate events. Changed the code to call repository.update even for create events
2) The async event queue was repeatedly dispatching the same events event after
a bucket moved to another node. We changed the async event queue code to filter out
events for buckets that are no longer present on this dispatching member.
Cleaning up the rebalancing test and adding new tests to make these scenarios
more reproducable.
Signed-off-by: Aparna Dharmakkan <ad...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aparnard/incubator-geode feature/GEODE-1558
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
----
commit d659a4ae97602e885638dd4081250aee02708a15
Author: Dan Smith <ds...@pivotal.io>
Date: 2016-06-28T22:33:51Z
GEODE-1558: Fixing failures due to rebalancing buckets during lucene index updates
There are two failures we're fixing here:
1) Calling repository.create for create events was leaving duplicate events in the
index because when a bucket fails over, the event is dispatched again on the new primary.
Using the isPossibleDuplicate flag did not work because it was not consistently set to
true for duplicate events. Changed the code to call repository.update even for create events
2) The async event queue was repeatedly dispatching the same events event after
a bucket moved to another node. We changed the async event queue code to filter out
events for buckets that are no longer present on this dispatching member.
Cleaning up the rebalancing test and adding new tests to make these scenarios
more reproducable.
Signed-off-by: Aparna Dharmakkan <ad...@pivotal.io>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #176: GEODE-1558: Fixing failures due to rebalancing b...
Posted by boglesby <gi...@git.apache.org>.
Github user boglesby commented on the issue:
https://github.com/apache/incubator-geode/pull/176
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #176: GEODE-1558: Fixing failures due to rebala...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #176: GEODE-1558: Fixing failures due to rebalancing b...
Posted by gesterzhou <gi...@git.apache.org>.
Github user gesterzhou commented on the issue:
https://github.com/apache/incubator-geode/pull/176
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---