You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by su...@apache.org on 2011/04/01 22:06:22 UTC
svn commit: r1087875 - in /hadoop/common/branches/branch-0.20-security: ./
src/core/org/apache/hadoop/ipc/ src/core/org/apache/hadoop/net/
src/core/org/apache/hadoop/security/ src/test/org/apache/hadoop/security/
Author: suresh
Date: Fri Apr 1 20:06:22 2011
New Revision: 1087875
URL: http://svn.apache.org/viewvc?rev=1087875&view=rev
Log:
HADOOP-7215. RPC clients must use network interface corresponding to the host in the client's kerberos principal key. Contributed by Suresh Srinivas.
Modified:
hadoop/common/branches/branch-0.20-security/CHANGES.txt
hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/ipc/Client.java
hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/net/NetUtils.java
hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/security/SecurityUtil.java
hadoop/common/branches/branch-0.20-security/src/test/org/apache/hadoop/security/TestSecurityUtil.java
Modified: hadoop/common/branches/branch-0.20-security/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security/CHANGES.txt?rev=1087875&r1=1087874&r2=1087875&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security/CHANGES.txt (original)
+++ hadoop/common/branches/branch-0.20-security/CHANGES.txt Fri Apr 1 20:06:22 2011
@@ -31,6 +31,9 @@ Release 0.20.204.0 - unreleased
HDFS-1258. Clearing namespace quota on "/" corrupts fs image.
(Aaron T. Myers via szetszwo)
+ HADOOP-7215. RPC clients must use network interface corresponding to
+ the host in the client's kerberos principal key. (suresh)
+
IMPROVEMENTS
HDFS-1541. Not marking datanodes dead when namenode in safemode.
Modified: hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/ipc/Client.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/ipc/Client.java?rev=1087875&r1=1087874&r2=1087875&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/ipc/Client.java (original)
+++ hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/ipc/Client.java Fri Apr 1 20:06:22 2011
@@ -18,8 +18,11 @@
package org.apache.hadoop.ipc;
+import java.net.InetAddress;
+import java.net.NetworkInterface;
import java.net.Socket;
import java.net.InetSocketAddress;
+import java.net.SocketException;
import java.net.SocketTimeoutException;
import java.net.UnknownHostException;
import java.net.ConnectException;
@@ -386,6 +389,27 @@ public class Client {
try {
this.socket = socketFactory.createSocket();
this.socket.setTcpNoDelay(tcpNoDelay);
+
+ /*
+ * Bind the socket to the host specified in the principal name of the
+ * client, to ensure Server matching address of the client connection
+ * to host name in principal passed.
+ */
+ if (UserGroupInformation.isSecurityEnabled()) {
+ KerberosInfo krbInfo =
+ remoteId.getProtocol().getAnnotation(KerberosInfo.class);
+ if (krbInfo != null && krbInfo.clientPrincipal() != null) {
+ String host =
+ SecurityUtil.getHostFromPrincipal(remoteId.getTicket().getUserName());
+
+ // If host name is a valid local address then bind socket to it
+ InetAddress localAddr = NetUtils.getLocalInetAddress(host);
+ if (localAddr != null) {
+ this.socket.bind(new InetSocketAddress(localAddr, 0));
+ }
+ }
+ }
+
// connection time out is 20s
NetUtils.connect(this.socket, remoteId.getAddress(), 20000);
this.socket.setSoTimeout(pingInterval);
Modified: hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/net/NetUtils.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/net/NetUtils.java?rev=1087875&r1=1087874&r2=1087875&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/net/NetUtils.java (original)
+++ hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/net/NetUtils.java Fri Apr 1 20:06:22 2011
@@ -22,8 +22,10 @@ import java.io.InputStream;
import java.io.OutputStream;
import java.net.InetAddress;
import java.net.InetSocketAddress;
+import java.net.NetworkInterface;
import java.net.Socket;
import java.net.SocketAddress;
+import java.net.SocketException;
import java.net.URI;
import java.net.UnknownHostException;
import java.nio.channels.SocketChannel;
@@ -281,7 +283,7 @@ public class NetUtils {
* case, the timeout argument is ignored and the timeout set with
* {@link Socket#setSoTimeout(int)} applies for reads.<br><br>
*
- * Any socket created using socket factories returned by {@link #NetUtils},
+ * Any socket created using socket factories returned by {@link NetUtils},
* must use this interface instead of {@link Socket#getInputStream()}.
*
* @see #getInputStream(Socket, long)
@@ -303,7 +305,7 @@ public class NetUtils {
* case, the timeout argument is ignored and the timeout set with
* {@link Socket#setSoTimeout(int)} applies for reads.<br><br>
*
- * Any socket created using socket factories returned by {@link #NetUtils},
+ * Any socket created using socket factories returned by {@link NetUtils},
* must use this interface instead of {@link Socket#getInputStream()}.
*
* @see Socket#getChannel()
@@ -332,7 +334,7 @@ public class NetUtils {
* case, the timeout argument is ignored and the write will wait until
* data is available.<br><br>
*
- * Any socket created using socket factories returned by {@link #NetUtils},
+ * Any socket created using socket factories returned by {@link NetUtils},
* must use this interface instead of {@link Socket#getOutputStream()}.
*
* @see #getOutputStream(Socket, long)
@@ -354,7 +356,7 @@ public class NetUtils {
* case, the timeout argument is ignored and the write will wait until
* data is available.<br><br>
*
- * Any socket created using socket factories returned by {@link #NetUtils},
+ * Any socket created using socket factories returned by {@link NetUtils},
* must use this interface instead of {@link Socket#getOutputStream()}.
*
* @see Socket#getChannel()
@@ -441,4 +443,27 @@ public class NetUtils {
}
return hostNames;
}
+
+ /**
+ * Checks if {@code host} is a local host name and return {@link InetAddress}
+ * corresponding to that address.
+ *
+ * @param host the specified host
+ * @return a valid local {@link InetAddress} or null
+ * @throws SocketException if an I/O error occurs
+ */
+ public static InetAddress getLocalInetAddress(String host)
+ throws SocketException {
+ if (host == null) {
+ return null;
+ }
+ InetAddress addr = null;
+ try {
+ addr = InetAddress.getByName(host);
+ if (NetworkInterface.getByInetAddress(addr) == null) {
+ addr = null; // Not a local address
+ }
+ } catch (UnknownHostException ignore) { }
+ return addr;
+ }
}
Modified: hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/security/SecurityUtil.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/security/SecurityUtil.java?rev=1087875&r1=1087874&r2=1087875&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/security/SecurityUtil.java (original)
+++ hadoop/common/branches/branch-0.20-security/src/core/org/apache/hadoop/security/SecurityUtil.java Fri Apr 1 20:06:22 2011
@@ -274,4 +274,13 @@ public class SecurityUtil {
throw new RuntimeException(ex);
}
}
+
+ /**
+ * Get the host name from the principal name of format <service>/host@realm.
+ * @param principalName principal name of format as described above
+ * @return host name if the the string conforms to the above format, else null
+ */
+ public static String getHostFromPrincipal(String principalName) {
+ return new KerberosName(principalName).getHostName();
+ }
}
Modified: hadoop/common/branches/branch-0.20-security/src/test/org/apache/hadoop/security/TestSecurityUtil.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security/src/test/org/apache/hadoop/security/TestSecurityUtil.java?rev=1087875&r1=1087874&r2=1087875&view=diff
==============================================================================
--- hadoop/common/branches/branch-0.20-security/src/test/org/apache/hadoop/security/TestSecurityUtil.java (original)
+++ hadoop/common/branches/branch-0.20-security/src/test/org/apache/hadoop/security/TestSecurityUtil.java Fri Apr 1 20:06:22 2011
@@ -82,4 +82,12 @@ public class TestSecurityUtil {
assertEquals("hdfs/" + local + "@REALM", SecurityUtil.getServerPrincipal(
"hdfs/_HOST@REALM", "0.0.0.0"));
}
+
+ @Test
+ public void testGetHostFromPrincipal() {
+ assertEquals("host",
+ SecurityUtil.getHostFromPrincipal("service/host@realm"));
+ assertEquals(null,
+ SecurityUtil.getHostFromPrincipal("service@realm"));
+ }
}