You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/07 17:09:24 UTC

[GitHub] [beam] robinyqiu commented on a change in pull request #12483: [BEAM-9182] [BEAM-10651] Support NULL query parameters in ZetaSQL

robinyqiu commented on a change in pull request #12483:
URL: https://github.com/apache/beam/pull/12483#discussion_r467164586



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java
##########
@@ -147,4 +165,35 @@ public int hashCode() {
       return super.hashCode();
     }
   }
+
+  private static class NamedDynamicParam extends SqlDynamicParam {

Review comment:
       Actually I don't think `equal` and `hashcode` is used at all.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org