You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Nathan Bubna (JIRA)" <de...@velocity.apache.org> on 2007/01/19 00:56:30 UTC

[jira] Resolved: (VELTOOLS-58) ValidatorTool does not respect 'bundle' property for message elements when generating client-side validation code.

     [ https://issues.apache.org/jira/browse/VELTOOLS-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Bubna resolved VELTOOLS-58.
----------------------------------

    Resolution: Fixed

> ValidatorTool does not respect 'bundle' property for message elements when generating client-side validation code.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: VELTOOLS-58
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-58
>             Project: Velocity Tools
>          Issue Type: Bug
>          Components: VelocityStruts
>    Affects Versions: 1.2, 1.3
>         Environment: JDK 1.4.2_09 / Tomcat 4.1.31 / Struts 1.2.7 / Commons-Validator 1.1.4
>            Reporter: Christopher Schultz
>             Fix For: 1.3
>
>         Attachments: ValidatorTool.java, VELTOOLS-58.patch
>
>
> I recently decided to split my application properties files into multiple bundles instead of one huge bundle in an effort to maintain some order. This required me to change my validation configuration to include the "bundle" property on my message elements:
>       <field property="questionTypeId"
>             depends="required,integer">
>         <arg position="0" bundle="Clinician" key="prompt.responseOption.questionTypeId"/>
>       </field>
> The ValidatorTool.getDynamicJavascript does not respect this setting and so I get messages like "The field ???en_US.responseOption.questionTypeId??? is required.".
> ValidatorTool.getDynamicJavascript first gets the global message bundle and re-uses it for all of the error messages emitted by the javascript generator:
> 		String message = Resources.getMessage(messages, locale, va, field);
> In order to respect the <msg>'s bundle, the code should instead be this:
> 		String message = Resources.getMessage(app,
> 						      request,
> 						      messages,
> 						      locale,
> 						      va,
> 						      field);
> It turns out that this doesn't fix the problem, although I'm sure that this change should be made. Perhaps someone with a better understanding of Struts/Validator/VelocityTools could shed some light on this situation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org