[GitHub] [pulsar] 315157973 commented on a change in pull request #12517: PIP 92: part-2 Topic policy across multiple clusters

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #12517:
URL: https://github.com/apache/pulsar/pull/12517#discussion_r764823917



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
##########
@@ -2278,7 +2279,7 @@ public void testGetReplicationClusters() throws Exception {
         topicPolicies.setReplicationClusters(topicClusters);
         Optional<TopicPolicies> optionalTopicPolicies = Optional.of(topicPolicies);
         topicPoliciesFuture.complete(optionalTopicPolicies);
-        when(topicPoliciesService.getTopicPoliciesAsyncWithRetry(any(), any(), any())).thenReturn(topicPoliciesFuture);
+        when(topicPoliciesService.getTopicPoliciesAsyncWithRetry(any(), any(), any(), anyBoolean())).thenReturn(topicPoliciesFuture);

Review comment:
       Whether it is true or false, mock is required here, otherwise there will be NPE.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org