[GitHub] [arrow] Anieway commented on a diff in pull request #36183: GH-20505: [C++] Optimize DELTA_BINARY_PACKED encoding

["Anieway (via GitHub)" <gi...@apache.org>]

Anieway commented on code in PR #36183:
URL: https://github.com/apache/arrow/pull/36183#discussion_r1241075777


##########
cpp/src/parquet/encoding.cc:
##########
@@ -2163,6 +2164,8 @@ class DeltaBitPackEncoder : public EncoderImpl, virtual public TypedEncoder<DTyp
   uint32_t total_value_count_{0};
   UT first_value_{0};
   UT current_value_{0};
+  UT min_delta_;

Review Comment:
   This could be done but would not change behavior as min_delta__ is set to the first value when encoding starts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org