You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "sherlock-lin (via GitHub)" <gi...@apache.org> on 2024/10/24 13:03:09 UTC
[PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
sherlock-lin opened a new pull request, #4518:
URL: https://github.com/apache/bookkeeper/pull/4518
<!-- or this PR is one task of an issue -->
Main Issue: #xyz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT closed pull request #4518: [Test] migrate-junit5-client-module and parameterized beforeEach
URL: https://github.com/apache/bookkeeper/pull/4518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #4518:
URL: https://github.com/apache/bookkeeper/pull/4518#issuecomment-2658538549
reopen's reason: rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4518:
URL: https://github.com/apache/bookkeeper/pull/4518#issuecomment-2436721652
@shoothzj please help review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "dlg99 (via GitHub)" <gi...@apache.org>.
dlg99 commented on PR #4518:
URL: https://github.com/apache/bookkeeper/pull/4518#issuecomment-2659915663
CI is failing:
```
[INFO]
Error: Errors:
Error: org.apache.bookkeeper.client.TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter
Error: Run 1: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
Error: Run 2: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
Error: Run 3: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #4518:
URL: https://github.com/apache/bookkeeper/pull/4518#issuecomment-2864829322
> testChangeEnsembleMaxNumWithWriter
@sherlock-lin take some time to deal with this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #4518:
URL: https://github.com/apache/bookkeeper/pull/4518#issuecomment-2807963175
reopen's reason: rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT closed pull request #4518: [Test] migrate-junit5-client-module and parameterized beforeEach
URL: https://github.com/apache/bookkeeper/pull/4518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Test] migrate-junit5-client-module and parameterized beforeEach [bookkeeper]
Posted by "sherlock-lin (via GitHub)" <gi...@apache.org>.
sherlock-lin commented on PR #4518:
URL: https://github.com/apache/bookkeeper/pull/4518#issuecomment-2437172104
> Overall looks good, can we use four indents in new code of `bookkeeper-server/src/test/java/org/apache/bookkeeper/client/HandleFailuresTest.java`?
sure😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org