You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/21 23:03:35 UTC
[GitHub] [incubator-gobblin] arjun4084346 opened a new pull request #3109: add metrics field in JobStatus schema
arjun4084346 opened a new pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #3109: add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109#discussion_r492470937
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/JobStatus.java
##########
@@ -40,7 +40,8 @@
private final long startTime;
private final long endTime;
@Setter
- private String message;
+ private String metrics;
Review comment:
Actually I added the setter in https://github.com/apache/incubator-gobblin/pull/3076 to add metrics in message field, so it can be set in internal projects. But now I am adding a separate metrics field for that purpose, which is to be set by custom job status retriever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #3109: add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
arjun4084346 commented on a change in pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109#discussion_r492470937
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/JobStatus.java
##########
@@ -40,7 +40,8 @@
private final long startTime;
private final long endTime;
@Setter
- private String message;
+ private String metrics;
Review comment:
Actually I added the setter in https://github.com/apache/incubator-gobblin/pull/3076 to add metrics in message field, so it can be set in internal projects. But now I am adding a separate metrics field for that purpose, which is to be set by custom job status retriever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3109: add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109#discussion_r492405907
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/JobStatus.java
##########
@@ -40,7 +40,8 @@
private final long startTime;
private final long endTime;
@Setter
- private String message;
+ private String metrics;
Review comment:
I think the Setter is needed for the message field too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3109: add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109#discussion_r492405907
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/JobStatus.java
##########
@@ -40,7 +40,8 @@
private final long startTime;
private final long endTime;
@Setter
- private String message;
+ private String metrics;
Review comment:
I think the Setter is needed for the message field too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3109: [GOBBLIN-1269] add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3109: add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109#discussion_r492405907
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/JobStatus.java
##########
@@ -40,7 +40,8 @@
private final long startTime;
private final long endTime;
@Setter
- private String message;
+ private String metrics;
Review comment:
I think the Setter is needed for the message field too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3109: [GOBBLIN-1269] add metrics field in JobStatus schema
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3109:
URL: https://github.com/apache/incubator-gobblin/pull/3109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org