You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/13 08:35:54 UTC

[GitHub] [incubator-druid] Fokko opened a new pull request #7651: Bump Checkstyle to 8.20

Fokko opened a new pull request #7651: Bump Checkstyle to 8.20
URL: https://github.com/apache/incubator-druid/pull/7651
 
 
   I would like to bump checkstyle to 8.20 since there are vulnerabilities detected.
   
   Checkstyle prior to 8.18 loads external DTDs by default, which can potentially lead to denial of service attacks or the leaking of confidential information.
   
   now `public void refresh() { }` is not allowed anymore, and the `{` needs to be on a new line. I think this is a nice change because when we start using an empty method, we don't touch the function's signature in git.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org