[jira] [Commented] (SQOOP-2659) Sqoop2: Do not stop providers that haven't been started in our integration test suite

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990512#comment-14990512 ] 

Sqoop QA bot commented on SQOOP-2659:
-------------------------------------

Testing file [SQOOP-2659.patch|https://issues.apache.org/jira/secure/attachment/12770636/SQOOP-2659.patch] against branch sqoop2 took 1:00:06.530655.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1544 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1847/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1847/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 93 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1847/console].

This message is automatically generated.

> Sqoop2: Do not stop providers that haven't been started in our integration test suite
> -------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2659
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2659
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2659.patch
>
>
> While investigating pre-commit hook failures on SQOOP-2652  I was side tracked at a lot by seeing various exceptions from Hive and Kafka test cases with {{NullPointerException}} and spending time investigating them.
> Upon further investigation I've noticed that the whole reason is that we're shutting down something that wasn't started and hence the NPE. The problem was that my newly added test case had added an {{assume}} statement in {{@Before*}} family of methods. The {{assume}} statement return false and stopped test execution before the Hive/Kite test cases got initialized. However the testng will execute all  tear down methods ({{@After*}} and not only those that have been initialized. Hence the tear down methods must be smart enough to not die if the initialization in fact did not happened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)