You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flagon.apache.org by GitBox <gi...@apache.org> on 2021/03/15 17:05:27 UTC
[GitHub] [incubator-flagon-useralejs] UncleGedd opened a new pull request #61: adds cypress journey test
UncleGedd opened a new pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61
## Adds cypress journey test
- Simple example of using cypress to assert on the page load log
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] poorejc commented on pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
poorejc commented on pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61#issuecomment-800710414
I'm going to close this PR. Have merged this commit with test, and pushed to new branch for discussion and testing here: https://github.com/apache/incubator-flagon-useralejs/tree/experimental-cypress
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] poorejc commented on pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
poorejc commented on pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61#issuecomment-802448522
Hi @UncleGedd sorry i've had my head in debugging. Did you add the custom label examples you built (re PR #64) on top of your commits for this PR (re PR #61)? Really what I'm asking is do I need to merge these separately, or should wait until we resolve last changes on #64 before merge to test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] confusingstraw commented on a change in pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
confusingstraw commented on a change in pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61#discussion_r595227679
##########
File path: package.json
##########
@@ -5,10 +5,13 @@
"main": "build/userale-2.1.1.js",
"scripts": {
"pretest": "gulp lint",
- "test": "gulp test",
+ "test": "gulp test && npm run journey:ci",
"build": "gulp build",
"clean": "gulp clean",
"dev": "gulp dev",
+ "journey": "cypress run",
+ "journey:debug": "cypress open",
+ "journey:ci": "start-server-and-test 'node example/server.js' 8000 journey",
Review comment:
Hi Gedd, thanks for the contribution. The code looks good, and the test seems to pass, but I needed to tweak the `package.json` scripts to be able to run locally (on Windows 10). The error I was getting was:
```
Error: expected <NPM script name that starts server> <url or port> <NPM script name that runs tests>
example: start-test start 8080 test
see https://github.com/bahmutov/start-server-and-test#use
```
This change seemed to do the trick though:
```suggestion
"journey:ci": "start-server-and-test example:run 8000 journey",
"example:run": "node example/server.js",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] poorejc closed pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
poorejc closed pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] asfgit merged pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] UncleGedd commented on pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
UncleGedd commented on pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61#issuecomment-804395798
It looks like I inadvertently added the custom label examples on top of the journey tests over in PR [#64](https://github.com/apache/incubator-flagon-useralejs/pull/64) (whoops!). I would recommend that we merge this PR first, it is unrelated to the custom label examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-flagon-useralejs] UncleGedd commented on a change in pull request #61: adds cypress journey test
Posted by GitBox <gi...@apache.org>.
UncleGedd commented on a change in pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61#discussion_r596073204
##########
File path: package.json
##########
@@ -5,10 +5,13 @@
"main": "build/userale-2.1.1.js",
"scripts": {
"pretest": "gulp lint",
- "test": "gulp test",
+ "test": "gulp test && npm run journey:ci",
"build": "gulp build",
"clean": "gulp clean",
"dev": "gulp dev",
+ "journey": "cypress run",
+ "journey:debug": "cypress open",
+ "journey:ci": "start-server-and-test 'node example/server.js' 8000 journey",
Review comment:
Got it, I think that's because I was using the global Node binary on my machine to start the `server.js` server, the "node" in `node example/server.js`. Your suggested change is the way to go though, thanks for the catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org