[GitHub] [flink] RocMarshal commented on a diff in pull request #22911: [FLINK-32495][connectors/common] Fix the bug that the shared thread factory causes the source alignment unit test to fail

["RocMarshal (via GitHub)" <gi...@apache.org>]

RocMarshal commented on code in PR #22911:
URL: https://github.com/apache/flink/pull/22911#discussion_r1247548797


##########
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorProviderTest.java:
##########
@@ -29,26 +29,25 @@ Licensed to the Apache Software Foundation (ASF) under one
 import org.apache.flink.runtime.operators.coordination.RecreateOnResetOperatorCoordinator;
 import org.apache.flink.runtime.source.event.ReaderRegistrationEvent;
 
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import java.time.Duration;
 import java.util.concurrent.CompletableFuture;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotEquals;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 /** Unit tests for {@link SourceCoordinatorProvider}. */
-public class SourceCoordinatorProviderTest {
+class SourceCoordinatorProviderTest {
 
     private static final OperatorID OPERATOR_ID = new OperatorID(1234L, 5678L);
     private static final int NUM_SPLITS = 10;
 
     private SourceCoordinatorProvider<MockSourceSplit> provider;
 
-    @Before
-    public void setup() {
+    @BeforeEach
+    void setup() {
         provider =
                 new SourceCoordinatorProvider<>(
                         "SourceCoordinatorProviderTest",

Review Comment:
   How about
   
   ```suggestion
                           this.getClass().getSimpleName(),
   ```
   ?



##########
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorProvider.java:
##########
@@ -130,6 +135,10 @@ public static class CoordinatorExecutorThreadFactory
 
         @Override
         public synchronized Thread newThread(Runnable r) {
+            checkState(
+                    t == null,
+                    "Please using the new CoordinatorExecutorThreadFactory,"
+                            + " this factory cannot new multiple threads.");

Review Comment:
   nice~.
   This design is in line with the principle that It should fail first once encounter error operation.



##########
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorProviderTest.java:
##########
@@ -125,4 +122,19 @@ public void testCallAsyncExceptionFailsJob() throws Exception {
                 Duration.ofSeconds(10L),
                 "The job did not fail before timeout.");
     }
+
+    @Test
+    void testCoordinatorExecutorThreadFactoryNewMultipleThread() {
+        SourceCoordinatorProvider.CoordinatorExecutorThreadFactory
+                coordinatorExecutorThreadFactory =
+                        new SourceCoordinatorProvider.CoordinatorExecutorThreadFactory(
+                                "test_coordinator_thread",
+                                new MockOperatorCoordinatorContext(
+                                        new OperatorID(1234L, 5678L), 3));
+
+        coordinatorExecutorThreadFactory.newThread(() -> {});
+        // coordinatorExecutorThreadFactory cannot create multiple threads.
+        assertThatThrownBy(() -> coordinatorExecutorThreadFactory.newThread(() -> {}))
+                .isInstanceOf(IllegalStateException.class);
+    }

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org