[GitHub] HyukjinKwon commented on a change in pull request #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hadoop 3 profile

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hadoop 3 profile
URL: https://github.com/apache/spark/pull/21588#discussion_r253250197
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
 ##########
 @@ -177,7 +177,10 @@ private[hive] class IsolatedClientLoader(
 
   protected def isSharedClass(name: String): Boolean = {
     val isHadoopClass =
-      name.startsWith("org.apache.hadoop.") && !name.startsWith("org.apache.hadoop.hive.")
+      name.startsWith("org.apache.hadoop.") && !name.startsWith("org.apache.hadoop.hive.") ||
+      // Also, includes configuration2 as a min fix for Hadoop 3+ for now. This is failed
+      // during class resolution. It is fine when 'sharesHadoopClasses' is disabled.
+      name.startsWith("org.apache.commons.configuration2.")
 
 Review comment:
   To all, BTW, this fix is needed to land Hadoop 3 support into Apache spark.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org