You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/02/27 23:32:00 UTC

Review Request 65823: Avoid copies of task reconciliation status updates.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65823/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 


Diff: https://reviews.apache.org/r/65823/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 65823: Avoid copies of task reconciliation status updates.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65823/#review198358
-----------------------------------------------------------



PASS: Mesos patch 65823 was successfully built and tested.

Reviews applied: `['65823']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65823

- Mesos Reviewbot Windows


On Feb. 27, 2018, 11:32 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65823/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2018, 11:32 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 
> 
> 
> Diff: https://reviews.apache.org/r/65823/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 65823: Avoid copies of task reconciliation status updates.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65823/#review198360
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Feb. 27, 2018, 3:32 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65823/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2018, 3:32 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 
> 
> 
> Diff: https://reviews.apache.org/r/65823/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Re: Review Request 65823: Avoid copies of task reconciliation status updates.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65823/#review198370
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65823]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 27, 2018, 11:32 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65823/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2018, 11:32 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 
> 
> 
> Diff: https://reviews.apache.org/r/65823/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>