[GitHub] matthiasblaesing commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version
URL: https://github.com/apache/incubator-netbeans/pull/535#issuecomment-414078030
 
 
   Thanks you for the update. This PR got a bit stale, so it would be great if you could squash the current commits and rebase the changes onto current master.
   
   Comments right now:
   - for the slf4j library, the name of the license file needs to be aligned with the binary it covers (or you need to place a `Files` header into the license file. So please update the name to `slf4j-api-1.7.2-license.txt`
   - the license requires the copyright to be included, so the file needs to be present with the year + names. Add a new license "MIT-SLF4J" or similar to `nbbuild/licenses` and reference that ffrom the license file in the module (the license text also needs to be included)
   - the unittest checking for Java7 Extension `CheckJava7ExtensionTest` could be removed (I assume that code was folded into the new version?)
   - unittests fail because spelling of message was changed and different file status are reported
   
   The unittests that rely on a remote service are indeed more integration test. You could change them to depend on a property (`jgittesthost` or something like that) to make it possible to run them from CLI, but not be run by default.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists