[GitHub] [santuario-xml-security-java] seanjmullan commented on pull request #69: adding RNG specified via system property

[GitBox <gi...@apache.org>]

seanjmullan commented on PR #69:
URL: https://github.com/apache/santuario-xml-security-java/pull/69#issuecomment-1176319862

   For other system properties, we typically prefix them with the package hierarchy to avoid name clashes, so I would recommend:
   
   `org.apache.xml.security.securerandom.algorithm`
   
   Otherwise, this fix looks ok to me, but I think @coheigea should give the approval since this is in the stax implementation.
   
   On a related issue though, I think we should not hard-code "SHA1PRNG" as the default. There are better alternatives in the JDK now. I would replace this with a call to `new SecureRandom()` or possibly `SecureRandom.getInstanceStrong()`. I haven't looked at the usage to see which is more appropriate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org