You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/05 19:44:08 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #14840: [fix](memory leak) Fix load fragment stage `QueryFragmentsCtx` is not destroyed
xinyiZzz opened a new pull request, #14840:
URL: https://github.com/apache/doris/pull/14840
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1338608942
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1338068075
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1338123607
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.95 seconds
load time: 477 seconds
storage size: 17123356274 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221205202544_clickbench_pr_58243.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1339091474
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1339093513
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #14840:
URL: https://github.com/apache/doris/pull/14840#discussion_r1040334273
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -510,7 +510,10 @@ void FragmentMgr::_exec_actual(std::shared_ptr<FragmentExecState> exec_state, Fi
std::lock_guard<std::mutex> lock(_lock);
_fragment_map.erase(exec_state->fragment_instance_id());
if (all_done && fragments_ctx) {
- _fragments_ctx_map.erase(fragments_ctx->query_id);
+ auto search = _fragments_ctx_map.find(fragments_ctx->query_id);
Review Comment:
Indeed, fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14840:
URL: https://github.com/apache/doris/pull/14840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1338697515
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #14840:
URL: https://github.com/apache/doris/pull/14840#discussion_r1040277014
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -510,7 +510,10 @@ void FragmentMgr::_exec_actual(std::shared_ptr<FragmentExecState> exec_state, Fi
std::lock_guard<std::mutex> lock(_lock);
_fragment_map.erase(exec_state->fragment_instance_id());
if (all_done && fragments_ctx) {
- _fragments_ctx_map.erase(fragments_ctx->query_id);
+ auto search = _fragments_ctx_map.find(fragments_ctx->query_id);
Review Comment:
why search it first? I think map.erase method will do this automanticly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1338610274
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14840: [fix](memory leak) Fix load fragment `QueryFragmentsCtx` is not destroyed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14840:
URL: https://github.com/apache/doris/pull/14840#issuecomment-1338697490
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org