You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "showuon (via GitHub)" <gi...@apache.org> on 2024/05/29 03:24:46 UTC
[PR] [hotfix][docs-zh] maven should require v3.8.6 [flink]
showuon opened a new pull request, #24863:
URL: https://github.com/apache/flink/pull/24863
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
We require maven v3.8.6 (not higher) to build flink, otherwise, it'll get error:
`Detected Maven Version: 3.9.6 is not in the allowed range [3.8.6,3.8.6].`
## Brief change log
Update the wrong requirement in maven.md in Chinese.
## Verifying this change
Only doc is changed.
## Does this pull request potentially affect one of the following parts:
Only doc is changed.
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #24863:
URL: https://github.com/apache/flink/pull/24863#issuecomment-2138622168
@reswqa, please help take a look at the small doc update PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620052845
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
Thanks @reswqa ! I understand.
So, in summary, the English version has no issue because it said `Maven (we require version 3.8.6)`, compared with Chinese version, it said `Maven 3.8.6 (recommended or higher)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620040735
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
I'm not trying to challenge the rationality of this change(i.e. I know we can only use 3.8.6). I just wonder does the en doc also need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24863:
URL: https://github.com/apache/flink/pull/24863#issuecomment-2136449270
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "723de4273c06f3974e3a21808e6c5cf8ed6f7b84",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "723de4273c06f3974e3a21808e6c5cf8ed6f7b84",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 723de4273c06f3974e3a21808e6c5cf8ed6f7b84 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #24863:
URL: https://github.com/apache/flink/pull/24863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620118257
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
My bad. Didn't get it. Updated in https://github.com/apache/flink/pull/24863/commits/5d747e02e92655c18f53bcdce9e36457f9633f70.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620086895
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
I mean you should also change this `.md` file.
https://github.com/apache/flink/blob/132722e1b43607fe2236ecbbc3ba1faad1ad147f/docs/content/docs/dev/configuration/maven.md?plain=1#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620010384
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
In English version [README.md](https://github.com/apache/flink/blob/master/README.md#building-apache-flink-from-source), we only mention we require maven v3.8.6:
`Maven (we require version 3.8.6)`
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
In English version [README.md](https://github.com/apache/flink/blob/master/README.md#building-apache-flink-from-source), we mention we require maven v3.8.6:
`Maven (we require version 3.8.6)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1619978915
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
Is the english version of this doc still say `Maven 3.8.6 (recommended or higher)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620040735
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
I'm not trying to challenge the rationality of this change(i.e. I know we can only use 3.8.6). I just wonder does the en doc also need this change? Because you only touch the zh doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #24863:
URL: https://github.com/apache/flink/pull/24863#discussion_r1620086895
##########
docs/content.zh/docs/dev/configuration/maven.md:
##########
@@ -28,7 +28,7 @@ under the License.
## 要求
-- Maven 3.8.6 (推荐或者使用更高版本)
Review Comment:
I means you should also change this `.md` file.
https://github.com/apache/flink/blob/132722e1b43607fe2236ecbbc3ba1faad1ad147f/docs/content/docs/dev/configuration/maven.md?plain=1#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]
Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #24863:
URL: https://github.com/apache/flink/pull/24863#issuecomment-2141398257
Thanks for the contribution, merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org