You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2009/10/10 17:19:03 UTC

svn commit: r823869 [2/2] - in /jakarta/jmeter/trunk: src/components/org/apache/jmeter/assertions/ src/components/org/apache/jmeter/control/gui/ src/components/org/apache/jmeter/extractor/ src/components/org/apache/jmeter/sampler/ src/components/org/ap...

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler.java Sat Oct 10 15:18:56 2009
@@ -294,7 +294,7 @@
      * @return string containing the headers, one per line
      */
     protected String getResponseHeaders(HttpURLConnection conn) {
-        StringBuffer headerBuf = new StringBuffer();
+        StringBuilder headerBuf = new StringBuilder();
         headerBuf.append(conn.getHeaderField(0));// Leave header as is
         // headerBuf.append(conn.getHeaderField(0).substring(0, 8));
         // headerBuf.append(" ");
@@ -380,7 +380,7 @@
      */
     private String getConnectionHeaders(HttpURLConnection conn) {
         // Get all the request properties, which are the headers set on the connection
-        StringBuffer hdrs = new StringBuffer(100);
+        StringBuilder hdrs = new StringBuilder(100);
         Map<String, List<String>> requestHeaders = conn.getRequestProperties();
         Set<Map.Entry<String, List<String>>> headerFields = requestHeaders.entrySet();
         for(Iterator<Map.Entry<String, List<String>>> i = headerFields.iterator(); i.hasNext();) {

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java Sat Oct 10 15:18:56 2009
@@ -260,7 +260,7 @@
      */
     private String sendPostData(PostMethod post) throws IOException {
         // Buffer to hold the post body, except file content
-        StringBuffer postedBody = new StringBuffer(1000);
+        StringBuilder postedBody = new StringBuilder(1000);
         HTTPFileArg files[] = getHTTPFiles();
         // Check if we should do a multipart/form-data or an
         // application/x-www-form-urlencoded post request
@@ -398,7 +398,7 @@
                     }
 
                     // Just append all the parameter values, and use that as the post body
-                    StringBuffer postBody = new StringBuffer();
+                    StringBuilder postBody = new StringBuilder();
                     PropertyIterator args = getArguments().iterator();
                     while (args.hasNext()) {
                         HTTPArgument arg = (HTTPArgument) args.next().getObjectValue();
@@ -652,7 +652,7 @@
      * @return string containing the headers, one per line
      */
     protected String getResponseHeaders(HttpMethod method) {
-        StringBuffer headerBuf = new StringBuffer();
+        StringBuilder headerBuf = new StringBuilder();
         org.apache.commons.httpclient.Header rh[] = method.getResponseHeaders();
         headerBuf.append(method.getStatusLine());// header[0] is not the status line...
         headerBuf.append("\n"); // $NON-NLS-1$
@@ -736,7 +736,7 @@
      */
     protected String getConnectionHeaders(HttpMethod method) {
         // Get all the request headers
-        StringBuffer hdrs = new StringBuffer(100);
+        StringBuilder hdrs = new StringBuilder(100);
         Header[] requestHeaders = method.getRequestHeaders();
         for(int i = 0; i < requestHeaders.length; i++) {
             // Exclude the COOKIE header, since cookie is reported separately in the sample
@@ -973,7 +973,7 @@
      */
     private String sendPutData(PutMethod put) throws IOException {
         // Buffer to hold the put body, except file content
-        StringBuffer putBody = new StringBuffer(1000);
+        StringBuilder putBody = new StringBuilder(1000);
         boolean hasPutBody = false;
 
         // Check if the header manager had a content type header
@@ -1009,7 +1009,7 @@
             }
 
             // Just append all the parameter values, and use that as the post body
-            StringBuffer putBodyContent = new StringBuffer();
+            StringBuilder putBodyContent = new StringBuilder();
             PropertyIterator args = getArguments().iterator();
             while (args.hasNext()) {
                 HTTPArgument arg = (HTTPArgument) args.next().getObjectValue();

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Sat Oct 10 15:18:56 2009
@@ -866,7 +866,7 @@
      * @throws MalformedURLException
      */
     public URL getUrl() throws MalformedURLException {
-        StringBuffer pathAndQuery = new StringBuffer(100);
+        StringBuilder pathAndQuery = new StringBuilder(100);
         String path = this.getPath();
         // Hack to allow entire URL to be provided in host field
         if (path.startsWith(HTTP_PREFIX)
@@ -924,7 +924,7 @@
              // We use the encoding which should be used according to the HTTP spec, which is UTF-8
              contentEncoding = EncoderCache.URL_ARGUMENT_ENCODING;
          }
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         PropertyIterator iter = getArguments().iterator();
         boolean first = true;
         while (iter.hasNext()) {
@@ -1031,7 +1031,7 @@
     @Override
     public String toString() {
         try {
-            StringBuffer stringBuffer = new StringBuffer();
+            StringBuilder stringBuffer = new StringBuilder();
             stringBuffer.append(this.getUrl().toString());
             // Append body if it is a post or put
             if(POST.equals(getMethod()) || PUT.equals(getMethod())) {
@@ -1093,7 +1093,7 @@
         res.sampleStart();
         try {
             byte[] responseData;
-            StringBuffer ctb=new StringBuffer("text/html"); // $NON-NLS-1$
+            StringBuilder ctb=new StringBuilder("text/html"); // $NON-NLS-1$
             fis = new FileInputStream(getPath());
             String contentEncoding = getContentEncoding();
             if (contentEncoding.length() > 0) {
@@ -1454,7 +1454,7 @@
     }
 
     protected static String encodeBackSlashes(String value) {
-        StringBuffer newValue = new StringBuffer();
+        StringBuilder newValue = new StringBuilder();
         for (int i = 0; i < value.length(); i++) {
             char charAt = value.charAt(i);
             if (charAt == '\\') { // $NON-NLS-1$

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java Sat Oct 10 15:18:56 2009
@@ -82,7 +82,7 @@
      */
     public String sendPostData(URLConnection connection, HTTPSampler sampler) throws IOException {
         // Buffer to hold the post body, except file content
-        StringBuffer postedBody = new StringBuffer(1000);
+        StringBuilder postedBody = new StringBuilder(1000);
 
         HTTPFileArg files[] = sampler.getHTTPFiles();
 
@@ -299,7 +299,7 @@
                     }
 
                     // Just append all the parameter values, and use that as the post body
-                    StringBuffer postBodyBuffer = new StringBuffer();
+                    StringBuilder postBodyBuffer = new StringBuilder();
                     PropertyIterator args = sampler.getArguments().iterator();
                     while (args.hasNext()) {
                         HTTPArgument arg = (HTTPArgument) args.next().getObjectValue();

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PutWriter.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PutWriter.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PutWriter.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PutWriter.java Sat Oct 10 15:18:56 2009
@@ -87,7 +87,7 @@
             ByteArrayOutputStream bos = new ByteArrayOutputStream();
 
             // Just append all the parameter values, and use that as the put body
-            StringBuffer putBodyBuffer = new StringBuffer();
+            StringBuilder putBodyBuffer = new StringBuilder();
             PropertyIterator args = sampler.getArguments().iterator();
             while (args.hasNext()) {
                 HTTPArgument arg = (HTTPArgument) args.next().getObjectValue();

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/SoapSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/SoapSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/SoapSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/SoapSampler.java Sat Oct 10 15:18:56 2009
@@ -107,7 +107,7 @@
 
     public String getSOAPActionQuoted() {
         String action = getSOAPAction();
-        StringBuffer sb = new StringBuffer(action.length()+2);
+        StringBuilder sb = new StringBuilder(action.length()+2);
         sb.append(DOUBLE_QUOTE);
         sb.append(action);
         sb.append(DOUBLE_QUOTE);
@@ -158,7 +158,7 @@
      */
     private String sendPostData(PostMethod post, final int length) {
         // Buffer to hold the post body, except file content
-        StringBuffer postedBody = new StringBuffer(1000);
+        StringBuilder postedBody = new StringBuilder(1000);
         final String xmlFile = getXmlFile();
         if (xmlFile != null && xmlFile.length() > 0) {
             // We just add placeholder text for file content

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/WebServiceSampler.java Sat Oct 10 15:18:56 2009
@@ -617,7 +617,7 @@
 
     public String convertSoapHeaders(Hashtable<String, String> ht) {
         Enumeration<String> en = ht.keys();
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         while (en.hasMoreElements()) {
             String key = en.nextElement();
             buf.append(key).append("=").append(ht.get(key)).append("\n"); //$NON-NLS-1$ //$NON-NLS-2$
@@ -631,7 +631,7 @@
 //     * @return String containing the lines
 //     */
 //    private String convertSoapHeaders(Enumeration en) {
-//        StringBuffer buf = new StringBuffer(100);
+//        StringBuilder buf = new StringBuilder(100);
 //        while (en.hasMoreElements()) {
 //            buf.append(en.nextElement()).append("\n"); //$NON-NLS-1$
 //        }

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java Sat Oct 10 15:18:56 2009
@@ -42,7 +42,7 @@
     }
 
     public final static String encode(byte[] bs) {
-        StringBuffer out = new StringBuffer("");
+        StringBuilder out = new StringBuilder();
         int bl = bs.length;
         for (int i = 0; i < bl; i += 3) {
             out.append(encodeAtom(bs, i, (bl - i)));
@@ -51,7 +51,7 @@
     }
 
     public final static String encodeAtom(byte[] b, int strt, int left) {
-        StringBuffer out = new StringBuffer("");
+        StringBuilder out = new StringBuilder();
         if (left == 1) {
             byte b1 = b[strt];
             int k = 0;

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPFileArgs.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPFileArgs.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPFileArgs.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPFileArgs.java Sat Oct 10 15:18:56 2009
@@ -136,7 +136,7 @@
      */
     @Override
     public String toString() {
-        StringBuffer str = new StringBuffer();
+        StringBuilder str = new StringBuilder();
         PropertyIterator iter = getHTTPFileArgsCollection().iterator();
         while (iter.hasNext()) {
             HTTPFileArg file = (HTTPFileArg) iter.next().getObjectValue();

Modified: jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java Sat Oct 10 15:18:56 2009
@@ -213,7 +213,7 @@
      * @return a String identifier for this sampler instance
      */
     private String whoAmI() {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append(Thread.currentThread().getName());
         sb.append("@");
         sb.append(Integer.toHexString(hashCode()));

Modified: jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java (original)
+++ jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java Sat Oct 10 15:18:56 2009
@@ -347,7 +347,7 @@
      * @return a String identifier for this test instance
      */
     private String whoAmI() {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append(Thread.currentThread().toString());
         sb.append("@");
         sb.append(Integer.toHexString(hashCode()));

Modified: jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/SleepTest.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/SleepTest.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/SleepTest.java (original)
+++ jakarta/jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/SleepTest.java Sat Oct 10 15:18:56 2009
@@ -209,7 +209,7 @@
      * @return a String identifier for this test instance
      */
     private String whoAmI() {
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append(Thread.currentThread().toString());
         sb.append("@");
         sb.append(Integer.toHexString(hashCode()));

Modified: jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java (original)
+++ jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java Sat Oct 10 15:18:56 2009
@@ -151,7 +151,7 @@
         DefaultConfiguration config = new DefaultConfiguration("rl-jdbc"); // $NON-NLS-1$
 
         if (log.isDebugEnabled()) {
-            StringBuffer sb = new StringBuffer(40);
+            StringBuilder sb = new StringBuilder(40);
             sb.append("MaxPool: ");
             sb.append(maxPool);
             sb.append(" Timeout: ");
@@ -175,7 +175,7 @@
         config.addChild(autoCommit);
 
         if (log.isDebugEnabled()) {
-            StringBuffer sb = new StringBuffer(40);
+            StringBuilder sb = new StringBuilder(40);
             sb.append("KeepAlive: ");
             sb.append(isKeepAlive());
             sb.append(" Age: ");
@@ -192,7 +192,7 @@
 
         String _username = getUsername();
         if (log.isDebugEnabled()) {
-            StringBuffer sb = new StringBuffer(40);
+            StringBuilder sb = new StringBuilder(40);
             sb.append("Driver: ");
             sb.append(getDriver());
             sb.append(" DbUrl: ");

Modified: jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java Sat Oct 10 15:18:56 2009
@@ -55,10 +55,7 @@
 
     // Does not need to be synch. because it is only accessed from the sampler thread
     // The ClientPool does access it in a different thread, but ClientPool is fully synch.
-    private transient Publisher PUB = null;
-
-    // Does not need to be synch. because only used by the sample method as a temporary buffer
-    private final StringBuffer BUFFER = new StringBuffer();
+    private transient Publisher PUB = null; // TODO URGENT probably needs to be synch.
 
     private static final FileServer FSERVER = FileServer.getFileServer();
 
@@ -134,23 +131,23 @@
         if (this.PUB == null) {
             this.initClient();
         }
+        StringBuilder buffer = new StringBuilder();
         int loop = this.getIterationCount();
         if (this.PUB != null) {
             result.sampleStart();
             for (int idx = 0; idx < loop; idx++) {
                 String tmsg = this.getMessageContent();
                 this.PUB.publish(tmsg);
-                this.BUFFER.append(tmsg);
+                buffer.append(tmsg);
             }
             result.sampleEnd();
-            String content = this.BUFFER.toString();
+            String content = buffer.toString();
             result.setBytes(content.getBytes().length);
             result.setResponseCode("message published successfully");
             result.setResponseMessage(loop + " messages published");
             result.setSuccessful(true);
             result.setResponseData(content.getBytes());
             result.setSampleCount(loop);
-            this.BUFFER.setLength(0);
         }
         return result;
     }

Modified: jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArguments.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArguments.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArguments.java (original)
+++ jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArguments.java Sat Oct 10 15:18:56 2009
@@ -149,7 +149,7 @@
      */
     @Override
     public String toString() {
-        StringBuffer str = new StringBuffer();
+        StringBuilder str = new StringBuilder();
         PropertyIterator iter = getArguments().iterator();
         while (iter.hasNext()) {
             LDAPArgument arg = (LDAPArgument) iter.next().getObjectValue();

Modified: jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java Sat Oct 10 15:18:56 2009
@@ -935,7 +935,7 @@
             {
                 final Attribute     attr = ait.next();
 
-                StringBuffer sb = new StringBuffer();
+                StringBuilder sb = new StringBuilder();
                 if (attr.size() == 1) {
                     sb.append(getWriteValue(attr.get()));
                 } else {

Modified: jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapExtClient.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapExtClient.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapExtClient.java (original)
+++ jakarta/jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapExtClient.java Sat Oct 10 15:18:56 2009
@@ -76,7 +76,7 @@
         DirContext dirContext;
         Hashtable<String, String> env = new Hashtable<String, String>();
         env.put(Context.INITIAL_CONTEXT_FACTORY, "com.sun.jndi.ldap.LdapCtxFactory"); // $NON-NLS-1$
-        StringBuffer sb = new StringBuffer(80);
+        StringBuilder sb = new StringBuilder(80);
         if (secure) {
             sb.append("ldaps://"); // $NON-NLS-1$
         } else {

Modified: jakarta/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/MailReaderSampler.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/MailReaderSampler.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/MailReaderSampler.java (original)
+++ jakarta/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/MailReaderSampler.java Sat Oct 10 15:18:56 2009
@@ -109,7 +109,7 @@
             // Get directory
             Message messages[] = folder.getMessages();
             Message message;
-            StringBuffer pdata = new StringBuffer();
+            StringBuilder pdata = new StringBuilder();
             pdata.append(messages.length);
             pdata.append(" messages found\n");
 
@@ -119,7 +119,7 @@
             }
 
             for (int i = 0; i < n; i++) {
-                StringBuffer cdata = new StringBuffer();
+                StringBuilder cdata = new StringBuilder();
                 SampleResult child = new SampleResult();
                 child.sampleStart();
                 message = messages[i];
@@ -188,7 +188,7 @@
         return parent;
     }
 
-    private void appendMessageData(StringBuffer cdata, Message message)
+    private void appendMessageData(StringBuilder cdata, Message message)
             throws MessagingException, IOException {
         cdata.append("Date: "); // $NON-NLS-1$
         cdata.append(message.getSentDate());// TODO - use a different format here?
@@ -242,7 +242,7 @@
         }
     }
 
-    private void appendMessageAsMime(StringBuffer cdata, Message message)
+    private void appendMessageAsMime(StringBuilder cdata, Message message)
             throws MessagingException, IOException {
         ByteArrayOutputStream bout = new ByteArrayOutputStream();
         message.writeTo(bout);

Modified: jakarta/jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java (original)
+++ jakarta/jmeter/trunk/test/src/org/apache/commons/cli/avalon/ClutilTestCase.java Sat Oct 10 15:18:56 2009
@@ -902,7 +902,7 @@
         assertNotNull(optionByID);
         assertEquals('n', optionByID.getDescriptor().getId());
 
-        final StringBuffer sb = CLUtil.describeOptions(options);
+        final StringBuilder sb = CLUtil.describeOptions(options);
         final String lineSeparator = System.getProperty("line.separator");
         assertEquals("Testing display of null description", "\t-n, --nulltest" + lineSeparator, sb.toString());
     }
@@ -950,7 +950,7 @@
 
         final List<CLOption> clOptions = parser.getArguments();
         final int size = clOptions.size();
-        StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         for (int i=0; i< size; i++){
             if (i>0) {
                 sb.append(" ");

Modified: jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/TestObjectFactory.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/TestObjectFactory.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/TestObjectFactory.java (original)
+++ jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/TestObjectFactory.java Sat Oct 10 15:18:56 2009
@@ -46,7 +46,7 @@
                 java.io.File infile = new java.io.File(file);
                 java.io.FileInputStream fis = new java.io.FileInputStream(infile);
                 java.io.InputStreamReader isr = new java.io.InputStreamReader(fis);
-                StringBuffer buf = new StringBuffer();
+                StringBuilder buf = new StringBuilder();
                 java.io.BufferedReader br = new java.io.BufferedReader(isr);
                 String line = null;
                 while ((line = br.readLine()) != null) {

Modified: jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/benchmark/ParseBenchmark.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/benchmark/ParseBenchmark.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/benchmark/ParseBenchmark.java (original)
+++ jakarta/jmeter/trunk/test/src/org/apache/jmeter/monitor/model/benchmark/ParseBenchmark.java Sat Oct 10 15:18:56 2009
@@ -45,7 +45,7 @@
             java.io.File infile = new java.io.File(file);
             java.io.FileInputStream fis = null;
             java.io.InputStreamReader isr = null;
-            StringBuffer buf = new StringBuffer();
+            StringBuilder buf = new StringBuilder();
             try {
                 fis = new java.io.FileInputStream(infile);
                 isr = new java.io.InputStreamReader(fis);

Modified: jakarta/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestHTTPMirrorThread.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestHTTPMirrorThread.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestHTTPMirrorThread.java (original)
+++ jakarta/jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestHTTPMirrorThread.java Sat Oct 10 15:18:56 2009
@@ -191,7 +191,7 @@
         OutputStream outputStream = clientSocket.getOutputStream();
         InputStream inputStream = clientSocket.getInputStream();
         // Construct body
-        StringBuffer postBodyBuffer = new StringBuffer();
+        StringBuilder postBodyBuffer = new StringBuilder();
         for(int i = 0; i < 1000; i++) {
             postBodyBuffer.append("abc");
         }
@@ -281,7 +281,7 @@
         outputStream = clientSocket.getOutputStream();
         inputStream = clientSocket.getInputStream();
         // Construct body
-        postBodyBuffer = new StringBuffer();
+        postBodyBuffer = new StringBuilder();
         for(int i = 0; i < 1000; i++) {
             postBodyBuffer.append("\u0364\u00c5\u2052");
         }

Modified: jakarta/jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java?rev=823869&r1=823868&r2=823869&view=diff
==============================================================================
--- jakarta/jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java (original)
+++ jakarta/jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java Sat Oct 10 15:18:56 2009
@@ -156,7 +156,7 @@
         // logprop("java.class.path");
         String cp = System.getProperty("java.class.path");
         String cpe[] = JOrphanUtils.split(cp, java.io.File.pathSeparator);
-        StringBuffer sb = new StringBuffer(3000);
+        StringBuilder sb = new StringBuilder(3000);
         sb.append("java.class.path=");
         for (int i = 0; i < cpe.length; i++) {
             sb.append("\n");



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org