You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by dw...@apache.org on 2010/06/22 18:55:56 UTC
svn commit: r956952 - in
/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc:
kernel/exps/MapEntry.java schema/SchemaGenerator.java
Author: dwoods
Date: Tue Jun 22 16:55:56 2010
New Revision: 956952
URL: http://svn.apache.org/viewvc?rev=956952&view=rev
Log:
OPENJPA-1700 FindBugs - Should be a static inner class. This class is an inner class, but does not use its embedded reference to the object which created it.
Modified:
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/MapEntry.java
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/SchemaGenerator.java
Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/MapEntry.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/MapEntry.java?rev=956952&r1=956951&r2=956952&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/MapEntry.java (original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/MapEntry.java Tue Jun 22 16:55:56 2010
@@ -128,7 +128,7 @@ public class MapEntry
_meta = meta;
}
- private class Entry<K,V> implements Map.Entry<K, V> {
+ private static class Entry<K,V> implements Map.Entry<K, V> {
private final K key;
private final V value;
Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/SchemaGenerator.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/SchemaGenerator.java?rev=956952&r1=956951&r2=956952&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/SchemaGenerator.java (original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/SchemaGenerator.java Tue Jun 22 16:55:56 2010
@@ -1062,7 +1062,7 @@ public class SchemaGenerator {
* An event corresponding to the generation of a schema object.
*/
@SuppressWarnings("serial")
- public class Event
+ public static class Event
extends EventObject {
private final int _total;