[GitHub] [incubator-superset] mistercrunch edited a comment on issue #7011: fix(filterbox): fixed runtime exception in filterbox for allow multiple selection false

[GitBox <gi...@apache.org>]

mistercrunch edited a comment on issue #7011: fix(filterbox): fixed  runtime exception in filterbox for allow multiple selection false
URL: https://github.com/apache/incubator-superset/pull/7011#issuecomment-471871467
 
 
   Did a bit of archeology, for reference, this line got added a long time back:
   https://github.com/apache/incubator-superset/pull/3668/files#diff-0da28640c22d45c00960bc6d8a4c3483R699
   
   This must be related to Filter Box that don't `Allow Multiple`:
   https://github.com/apache/incubator-superset/pull/6523
   
   All in all, LGTM, it appears the code following what is altered here is assuming the input may or may not be a `list`
   
   Leaving the PR open so others can intercepts, otherwise will merge in a few days.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org