You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Dapeng Sun (JIRA)" <ji...@apache.org> on 2016/06/21 03:04:57 UTC

[jira] [Resolved] (CRYPTO-72) CryptoCipherFactory.getInstance does unnecessary class instantiation

     [ https://issues.apache.org/jira/browse/CRYPTO-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dapeng Sun resolved CRYPTO-72.
------------------------------
    Resolution: Fixed
      Assignee: Dapeng Sun

> CryptoCipherFactory.getInstance does unnecessary class instantiation
> --------------------------------------------------------------------
>
>                 Key: CRYPTO-72
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-72
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Dapeng Sun
>
> The CryptoCipherFactory.getInstance method calls getCipherClasses which splits the string containing the class name(s) and then creates an instance of each (if possible) using ReflectionUtils.getClassByName.
> However the getInstance method stops processing on the first successful class, so any subsequent entries are not used.
> This is wasteful; the call to ReflectionUtils.getClassByName should only be done if it is going to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)