You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/22 04:44:15 UTC
[GitHub] [airflow] akotlar opened a new issue #13242: [ui] Tree view provides inconsistent representation of dependent task views
akotlar opened a new issue #13242:
URL: https://github.com/apache/airflow/issues/13242
**Apache Airflow version**: 2.0.0
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release): NAME="Ubuntu 18.04.5 LTS"
- **Kernel** (e.g. `uname -a`): Linux 18.04.1-Ubuntu SMP
- **Install tools**:
- **Others**:
**What happened**:
Tree view does not properly represent the relationship between dependent task groups. Names are completely wrong.
**What you expected to happen**:
Task groups to be descendants of one another. Names to be correct, prefixed by the name of the task group
**How to reproduce it**:
Reproduction attached. TL;DR:
```python
with DAG(dag_id=DAG_NAME,
default_args=default_args,
schedule_interval='@daily',
max_active_runs=1,
catchup=False,
tags=['test'],
is_paused_upon_creation=True) as dag:
folders = ['test1', 'test2', 'test3', 'test4']
start = DummyOperator(task_id="start")
with TaskGroup("step1") as task_group1:
for path in folders:
f1 = PythonOperator(
task_id=path,
python_callable=fn1
)
with TaskGroup("step2") as task_group2:
for path in folders:
f2 = PythonOperator(
task_id=path,
python_callable=fn2
)
with TaskGroup("step3") as task_group3:
for path in folders:
f3 = PythonOperator(
task_id=path,
python_callable=fn3
)
start >> task_group1 >> task_group2 >> task_group3
```
**How often does this problem occur? Once? Every time etc?**
Every time
[repo.py.gz](https://github.com/apache/airflow/files/5727820/repo.py.gz)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi edited a comment on issue #13242: [ui] Tree view provides inconsistent representation of dependent task views
Posted by GitBox <gi...@apache.org>.
bbovenzi edited a comment on issue #13242:
URL: https://github.com/apache/airflow/issues/13242#issuecomment-777028653
It does seem like the Tree View is working as intended. It's just that a tree diagram isn't the best way to represent all types of DAGs.
I think we would need to add the ability for nodes in the tree to merge back together. Like so:
<img width="419" alt="Screen Shot 2021-02-10 at 1 39 55 PM" src="https://user-images.githubusercontent.com/4600967/107569427-e75bcf00-6bad-11eb-8fc6-3d39d5643a3c.png">
But then it isn't a tree but a graph so it wouldn't be a trivial change. More of a feature request than a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on issue #13242: [ui] Tree view provides inconsistent representation of dependent task views
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #13242:
URL: https://github.com/apache/airflow/issues/13242#issuecomment-777028653
It does seem like the Tree View is working as intended. It's just that a tree diagram isn't the best way to represent all types of DAGs.
I think we would need to add the ability for nodes in the tree to merge back together. Like so:
<img width="419" alt="Screen Shot 2021-02-10 at 1 39 55 PM" src="https://user-images.githubusercontent.com/4600967/107569427-e75bcf00-6bad-11eb-8fc6-3d39d5643a3c.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] akotlar commented on issue #13242: [ui] Tree view provides inconsistent representation of dependent task views
Posted by GitBox <gi...@apache.org>.
akotlar commented on issue #13242:
URL: https://github.com/apache/airflow/issues/13242#issuecomment-777625779
Agreed, this should be a feature request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Miksu82 commented on issue #13242: [ui] Tree view provides inconsistent representation of dependent task views
Posted by GitBox <gi...@apache.org>.
Miksu82 commented on issue #13242:
URL: https://github.com/apache/airflow/issues/13242#issuecomment-816659741
What about showing only the task groups (and tasks that are not in any group) in the tree view and then when the task group is clicked (or hovered over) it shows the tasks belonging to that task group.
So the tree view would only show.
```
[DAG]
\
Start
\
step1
\
step2
\
step3
```
would that simplify the implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed issue #13242: [ui] Tree view provides inconsistent representation of dependent task views
Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #13242:
URL: https://github.com/apache/airflow/issues/13242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org