You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/28 13:43:53 UTC
[GitHub] [avro] zcsizmadia opened a new pull request #1481: AVRO-3330: Avrogen returns success if help requested
zcsizmadia opened a new pull request #1481:
URL: https://github.com/apache/avro/pull/1481
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO-3330) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/AVRO-3330
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1481:
URL: https://github.com/apache/avro/pull/1481#issuecomment-1025220811
Thank you for the contribution, @zcsizmadia !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1481:
URL: https://github.com/apache/avro/pull/1481#discussion_r794715971
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -29,7 +29,8 @@ static int Main(string[] args)
if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
- return 1;
+ // Return success if help requested
+ return args.Length == 0 ? 1 : 0;
Review comment:
` // Print usage if no arguments provided or help requested
if (args.Length == 0)
{
Usage();
return 1;
}
if (args[0] == "-h" || args[0] == "--help")
{
Usage();
return 0;
}`
This seems cleaner. No reason to add another evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on a change in pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on a change in pull request #1481:
URL: https://github.com/apache/avro/pull/1481#discussion_r794752294
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -29,7 +29,8 @@ static int Main(string[] args)
if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
- return 1;
+ // Return success if help requested
+ return args.Length == 0 ? 1 : 0;
Review comment:
I am not sure I agree with that statement: double the code for a very simple condition. However I modded the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1481:
URL: https://github.com/apache/avro/pull/1481#discussion_r794715971
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -29,7 +29,8 @@ static int Main(string[] args)
if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
- return 1;
+ // Return success if help requested
+ return args.Length == 0 ? 1 : 0;
Review comment:
` // Print usage if no arguments provided or help requested
if (args.Length == 0)
{
Usage();
return 1;
}`
```
if (args[0] == "-h" || args[0] == "--help")
{
Usage();
return 0;
}
```
This seems cleaner. No reason to add another evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1481:
URL: https://github.com/apache/avro/pull/1481#discussion_r794715971
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -29,7 +29,8 @@ static int Main(string[] args)
if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
- return 1;
+ // Return success if help requested
+ return args.Length == 0 ? 1 : 0;
Review comment:
` // Print usage if no arguments provided or help requested
if (args.Length == 0)
{
Usage();
return 1;
}`
` if (args[0] == "-h" || args[0] == "--help")
{
Usage();
return 0;
}`
This seems cleaner. No reason to add another evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1481:
URL: https://github.com/apache/avro/pull/1481#discussion_r794715971
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -29,7 +29,8 @@ static int Main(string[] args)
if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
- return 1;
+ // Return success if help requested
+ return args.Length == 0 ? 1 : 0;
Review comment:
`// Print usage if no arguments provided or help requested
if (args.Length == 0)
{
Usage();
return 1;
}
if (args[0] == "-h" || args[0] == "--help")
{
Usage();
return 0;
}`
This seems cleaner. No reason to add another evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1481:
URL: https://github.com/apache/avro/pull/1481#discussion_r794715971
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -29,7 +29,8 @@ static int Main(string[] args)
if (args.Length == 0 || args[0] == "-h" || args[0] == "--help")
{
Usage();
- return 1;
+ // Return success if help requested
+ return args.Length == 0 ? 1 : 0;
Review comment:
` // Print usage if no arguments provided or help requested
if (args.Length == 0)
{
Usage();
return 1;
}`
` if (args[0] == "-h" || args[0] == "--help")
{
Usage();
return;
}`
This seems cleaner. No reason to add another evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1481: AVRO-3330: Avrogen returns success if help requested
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1481:
URL: https://github.com/apache/avro/pull/1481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org