[GitHub] [arrow] mapleFU commented on a diff in pull request #36463: GH-36446: [C++] ConcatenateImpl fixing style

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #36463:
URL: https://github.com/apache/arrow/pull/36463#discussion_r1254356247


##########
cpp/src/arrow/array/concatenate.cc:
##########
@@ -169,22 +169,26 @@ Status PutOffsets(const std::shared_ptr<Buffer>& src, Offset first_offset, Offse
   return Status::OK();
 }
 
+// Implement of `arrow::Concatenate`.
+// N.B. The ConcatenateImpl should accept a reference to a vector of ArrayData,
+// instead of a temporary value.

Review Comment:
   Well not a todo, just tell the user not to use like:
   
   ```c++
   ConcatenateImpl i{/* get prvalue */GenerateArray()};
   i.concate()
   ```
   
   That would be unsafe, because `ConcatenateImpl` holds a const reference. If you think it's not neccessary, I'll remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org