You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/06 19:13:04 UTC
[GitHub] [superset] graceguo-supercat opened a new issue #16124: [table editor] Change virtual dataset won't work
graceguo-supercat opened a new issue #16124:
URL: https://github.com/apache/superset/issues/16124
#### How to reproduce the bug
1. Go to a chart using virtual dataset, which has sql query
2. Click on Edit dataset
3. change sql: (in my case, change `> '2021-07-01'` to `= '2021-07-01'` )
<img width="874" alt="Screen Shot 2021-08-06 at 12 06 53 PM" src="https://user-images.githubusercontent.com/27990562/128560368-0c7cd64b-5710-4ad0-bb5c-a3bd578524c1.png">
4. save it
5. It looks dataset is updated with success message
6. But if you open Edit dataset modal, yo will see old sql
7. in the API, you can see the old sql is sent out in the update API:
<img width="1203" alt="Screen Shot 2021-08-06 at 12 07 26 PM" src="https://user-images.githubusercontent.com/27990562/128560302-e5dfe5eb-5a75-44f0-9a8f-87e4a54e249c.png">
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed issue #16124:
URL: https://github.com/apache/superset/issues/16124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894481275
thanks for filing, we also noticed it. moved it to p0
this is pretty sever so we are picking it up from you guys. @eschutho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894575904
I think the root cause is from [this PR](15887). But since the change is large, i couldn't revert it from airbnb's release branch. @zhaoyongjie Please fix forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894579982
@graceguo-supercat I am on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph edited a comment on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
yousoph edited a comment on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894531253
Dataset settings also aren't getting saved (Owner, cache timeout, whether to populate autocomplete filters options for example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894513192
@junlincc thanks for prioritizing this!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894531253
Dataset settings also aren't getting saved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on issue #16124: [table editor] Change virtual dataset won't work
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #16124:
URL: https://github.com/apache/superset/issues/16124#issuecomment-894575904
I think the root cause is from [this PR](15887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org